[PR #18458] [CLOSED] Bug wrong chat rename model #47848

New Issue

GiteaMirror · 2026-04-29T23:14:47-05:00

GiteaMirror commented

2026-04-29 23:14:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18458
Author: @druellan
Created: 10/20/2025
Status: ❌ Closed

Base: main ← Head: bug-wrong-chat-rename-model

📝 Commits (2)

ad8b9f1 fix: fetch the correct task model to pass to the generateTitle endpoint
5ffb033 Fix: wrong model being used for title generation when manually editing a chat name (server fix)

📊 Changes

2 files changed (+7 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/tasks.py (+6 -5)
📝 backend/open_webui/utils/task.py (+1 -1)

📄 Description

Pull Request Checklist

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

generateTitle() requires a model ID to perform the title generation. The frontend is sending the chat model, that can be invalid if that model was disabled or removed on the backend. In that case, the endpoint drops the request before testing if the task model is valid and running.

Fixed

Swapped the detection, so, we test for a TASK_MODEL and TASK_MODEL_EXTERNAL first, and then we drop the request if no valid model is found.
backend\open_webui\routers\tasks.py:

    model_id = form_data["model"]

    # Check if the user has a custom task model
    # If the user has a custom task model, use that model
    task_model_id = get_task_model_id(
        model_id,
        request.app.state.config.TASK_MODEL,
        request.app.state.config.TASK_MODEL_EXTERNAL,
        models,
    )

    if task_model_id not in models:
        raise HTTPException(
            status_code=status.HTTP_404_NOT_FOUND,
            detail="Model not found",
        )

Also, backend\open_webui\utils\task.py received a small update (if task_model_id in models) to avoid a hard error if the model_id is invalid:

    if task_model_id in models and models[task_model_id].get("connection_type") == "local":
        if task_model and task_model in models:
            task_model_id = task_model
    else:
        if task_model_external and task_model_external in models:
            task_model_id = task_model_external

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18458 **Author:** [@druellan](https://github.com/druellan) **Created:** 10/20/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `bug-wrong-chat-rename-model` --- ### 📝 Commits (2) - [`ad8b9f1`](https://github.com/open-webui/open-webui/commit/ad8b9f13104c25cba83e79bdeb9e8a0b52bd5b57) fix: fetch the correct task model to pass to the generateTitle endpoint - [`5ffb033`](https://github.com/open-webui/open-webui/commit/5ffb033c7f54add993de2f4685906c3908376e4e) Fix: wrong model being used for title generation when manually editing a chat name (server fix) ### 📊 Changes **2 files changed** (+7 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/tasks.py` (+6 -5) 📝 `backend/open_webui/utils/task.py` (+1 -1) </details> ### 📄 Description # Pull Request Checklist - [X] **Target branch:** Verify that the pull request targets the `dev` branch. Not targeting the `dev` branch may lead to immediate closure of the PR. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description. - [X] **Agentic AI Code:**: Confirm this Pull Request is **not written by any AI Agent** or has at least gone through additional human review **and** manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - generateTitle() requires a model ID to perform the title generation. The frontend is sending the chat model, that can be invalid if that model was disabled or removed on the backend. In that case, the endpoint drops the request before testing if the task model is valid and running. ### Fixed Swapped the detection, so, we test for a TASK_MODEL and TASK_MODEL_EXTERNAL first, and then we drop the request if no valid model is found. `backend\open_webui\routers\tasks.py`: ``` model_id = form_data["model"] # Check if the user has a custom task model # If the user has a custom task model, use that model task_model_id = get_task_model_id( model_id, request.app.state.config.TASK_MODEL, request.app.state.config.TASK_MODEL_EXTERNAL, models, ) if task_model_id not in models: raise HTTPException( status_code=status.HTTP_404_NOT_FOUND, detail="Model not found", ) ``` Also, `backend\open_webui\utils\task.py` received a small update (`if task_model_id in models`) to avoid a hard error if the model_id is invalid: ``` if task_model_id in models and models[task_model_id].get("connection_type") == "local": if task_model and task_model in models: task_model_id = task_model else: if task_model_external and task_model_external in models: task_model_id = task_model_external ``` ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 23:14:47 -05:00

GiteaMirror closed this issue

2026-04-29 23:14:49 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47848