[PR #18087] [CLOSED] fix: issue 18010 fix oauth 2 1 issue #47715

New Issue

GiteaMirror · 2026-04-29T23:03:47-05:00

GiteaMirror commented

2026-04-29 23:03:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18087
Author: @hsuyuming
Created: 10/6/2025
Status: ❌ Closed

Base: dev ← Head: fix/issue-18010-fix-oauth-2_1-issue

📝 Commits (1)

8910116 fix: Enhance OAuth client with PKCE support and explicit credentials

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/oauth.py (+7 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources? -> No
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation? -> No
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixing bug https://github.com/open-webui/open-webui/issues/18010, Enhance OAuth client with PKCE support and explicit credentials

Fixed

Add code_challenge_method="S256" to enable PKCE (Proof Key for Code Exchange)
Explicitly pass client_id and client_secret when authorizing access tokens which required by OAuth secured MCP server

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18087 **Author:** [@hsuyuming](https://github.com/hsuyuming) **Created:** 10/6/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/issue-18010-fix-oauth-2_1-issue` --- ### 📝 Commits (1) - [`8910116`](https://github.com/open-webui/open-webui/commit/891011627c2410a266d841099d33654348279451) fix: Enhance OAuth client with PKCE support and explicit credentials ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/oauth.py` (+7 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? -> No - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? -> No - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixing bug https://github.com/open-webui/open-webui/issues/18010, Enhance OAuth client with PKCE support and explicit credentials ### Fixed - Add code_challenge_method="S256" to enable PKCE (Proof Key for Code Exchange) - Explicitly pass client_id and client_secret when authorizing access tokens which required by OAuth secured MCP server ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 23:03:47 -05:00

GiteaMirror closed this issue

2026-04-29 23:03:51 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47715