[PR #17012] [MERGED] fix: PKCE requires no secret, with no secret the login button does not eve… #47344

New Issue

GiteaMirror · 2026-04-29T22:32:40-05:00

GiteaMirror commented

2026-04-29 22:32:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/17012
Author: @thomascooper
Created: 8/28/2025
Status: ✅ Merged
Merged: 8/31/2025
Merged by: @tjbck

Base: dev ← Head: fork/feature/20250828-auth-oidc-support-pkce

📝 Commits (1)

9d80cc3 PKCE requires no secret, with no secret the login button does not ever show

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/config.py (+1 -1)

📄 Description

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
[NA] Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
[NA] Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[NA] Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Changed

Added an or conidition to the block that controls generic ODIC instanciation based to look for OAUTH_CODE_CHALLENGE_METHOD or OAUTH_CLIENT_SECRET

Fixed

OIDC configured correctly with PKCE would not show SSO login button

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/17012 **Author:** [@thomascooper](https://github.com/thomascooper) **Created:** 8/28/2025 **Status:** ✅ Merged **Merged:** 8/31/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fork/feature/20250828-auth-oidc-support-pkce` --- ### 📝 Commits (1) - [`9d80cc3`](https://github.com/open-webui/open-webui/commit/9d80cc3b2d39e5e986b53ba19d66379643e80645) PKCE requires no secret, with no secret the login button does not ever show ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+1 -1) </details> ### 📄 Description - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [NA] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [NA] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [NA] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### This patch fixes the issue that if generic OIDC is being used with PKCE and no client secret, then the SSO login button does not show up. ### Changed - Added an or conidition to the block that controls generic ODIC instanciation based to look for OAUTH_CODE_CHALLENGE_METHOD or OAUTH_CLIENT_SECRET ### Fixed - OIDC configured correctly with PKCE would not show SSO login button ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:32:40 -05:00

GiteaMirror closed this issue

2026-04-29 22:32:43 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47344