[PR #16850] [MERGED] FIX: Playwright Timeout (ms) interpreted as seconds #47305

New Issue

GiteaMirror · 2026-04-29T22:29:42-05:00

GiteaMirror commented

2026-04-29 22:29:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16850
Author: @rgaricano
Created: 8/23/2025
Status: ✅ Merged
Merged: 8/23/2025
Merged by: @tjbck

Base: dev ← Head: dev-FIX_playwright_timeout

📝 Commits (1)

093af75 FIX: Playwright Timeout (ms) interpreted as seconds

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/retrieval/web/utils.py (+1 -1)

📄 Description

Fix for Playwright Timeout (ms) interpreted as seconds.

To address https://github.com/open-webui/open-webui/issues/16801

In Frontend Playwright Timeout is setted as (ms), but in backend is interpreted as (s) doing a time conversion for playwright_timeout var (that have to be in ms).

& as Originally posted by @rawbby in #16801

I personally think milliseconds are a reasonable choice for the timeout. Maybe the conversion should be fixed, not the label.
This would further not break existing configurations from users that rely on their current config.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16850 **Author:** [@rgaricano](https://github.com/rgaricano) **Created:** 8/23/2025 **Status:** ✅ Merged **Merged:** 8/23/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `dev-FIX_playwright_timeout` --- ### 📝 Commits (1) - [`093af75`](https://github.com/open-webui/open-webui/commit/093af754e7dd6471b40f838dda8aa39ead5edc8b) FIX: Playwright Timeout (ms) interpreted as seconds ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/web/utils.py` (+1 -1) </details> ### 📄 Description Fix for Playwright Timeout (ms) interpreted as seconds. To address https://github.com/open-webui/open-webui/issues/16801 In Frontend Playwright Timeout is setted as (ms), but in backend is interpreted as (s) doing a time conversion for playwright_timeout var (that have to be in ms). & as _Originally posted by @rawbby in [#16801](https://github.com/open-webui/open-webui/issues/16801#issuecomment-3216782565)_ > I personally think milliseconds are a reasonable choice for the timeout. Maybe the conversion should be fixed, not the label. > This would further not break existing configurations from users that rely on their current config. > ______ ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:29:42 -05:00

GiteaMirror closed this issue

2026-04-29 22:29:47 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47305