[PR #16687] [CLOSED] fix: don't prematurely close regular reasoning blocks after tool calls #47256

New Issue

GiteaMirror · 2026-04-29T22:25:41-05:00

GiteaMirror commented

2026-04-29 22:25:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16687
Author: @Ithanil
Created: 8/17/2025
Status: ❌ Closed

Base: dev ← Head: fix_reasoning_after_toolcall

📝 Commits (1)

15cddda fix prematurely closed reasoning blocks after tool calls

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+3 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
[] Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

2e36540023a3baf4a323d9b9a401a1689b8da012 introduced handling of tool calls inside reasoning blocks (fixing https://github.com/open-webui/open-webui/issues/16305 ), by prematurely closing reasoning blocks. However, the mechanism would also apply when subsequent reasoning blocks would follow regular tool calls (i.e. outside reasoning blocks), effectively leaving only the first token of the reasoning block inside the reasoning block and rendering the rest as regular text.

Example:

... more reasoning content would follow including the final </think> tag, all rendered as regular text.

The present PR makes sure the premature closure is only activated when there is delta_tool_call.

IMPORTANT: I have NO way to test if https://github.com/open-webui/open-webui/issues/16305 remains fixed! Please verify. What I can confirm is that the issue shown in the screenshot is fixed.

Fixed

Processing of reasoning blocks after tool calls

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16687 **Author:** [@Ithanil](https://github.com/Ithanil) **Created:** 8/17/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix_reasoning_after_toolcall` --- ### 📝 Commits (1) - [`15cddda`](https://github.com/open-webui/open-webui/commit/15cddda878c86d5c805b66dd997087cf9e52d90a) fix prematurely closed reasoning blocks after tool calls ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+3 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description [2e36540023a3baf4a323d9b9a401a1689b8da012 ](https://github.com/open-webui/open-webui/commit/2e36540023a3baf4a323d9b9a401a1689b8da012) introduced handling of tool calls inside reasoning blocks (fixing https://github.com/open-webui/open-webui/issues/16305 ), by prematurely closing reasoning blocks. However, the mechanism would also apply when subsequent reasoning blocks would follow regular tool calls (i.e. outside reasoning blocks), effectively leaving only the first token of the reasoning block inside the reasoning block and rendering the rest as regular text. Example: <img width="946" height="401" alt="Screenshot From 2025-08-17 16-06-50" src="https://github.com/user-attachments/assets/00c04f48-555e-4256-977e-b5d4066e085a" /> ... more reasoning content would follow including the final `</think>` tag, all rendered as regular text. The present PR makes sure the premature closure is only activated when there is delta_tool_call. **IMPORTANT**: I have NO way to test if https://github.com/open-webui/open-webui/issues/16305 remains fixed! **Please verify**. What I *can* confirm is that the issue shown in the screenshot is fixed. ### Fixed - Processing of reasoning blocks after tool calls ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:25:42 -05:00

GiteaMirror closed this issue

2026-04-29 22:25:43 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47256