[PR #16321] [MERGED] Feat: enhance accessibility of menu #47140

New Issue

GiteaMirror · 2026-04-29T22:14:07-05:00

GiteaMirror commented

2026-04-29 22:14:07 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16321
Author: @sinejespersen
Created: 8/6/2025
Status: ✅ Merged
Merged: 8/6/2025
Merged by: @tjbck

Base: dev ← Head: feature/more-accessible-menu

📝 Commits (4)

502a368 aria-hidden on icons to hide them from assistive technology
ba1e32f add aria-label to labelless button to enhance accessibility
9df790a make buttons DropdownMenuItems to make them accessible by keyboard, add handling of highContrastMode
52ef3e7 add aria-labels and aria-pressed to enhance accessibility

📊 Changes

8 files changed (+25 additions, -7 deletions)

View changed files

📝 src/lib/components/chat/ModelSelector/ModelItem.svelte (+1 -0)
📝 src/lib/components/chat/ModelSelector/ModelItemMenu.svelte (+11 -5)
📝 src/lib/components/chat/ModelSelector/Selector.svelte (+8 -2)
📝 src/lib/components/icons/ChatBubbleOval.svelte (+1 -0)
📝 src/lib/components/icons/Eye.svelte (+1 -0)
📝 src/lib/components/icons/EyeSlash.svelte (+1 -0)
📝 src/lib/components/icons/Link.svelte (+1 -0)
📝 src/lib/components/icons/Search.svelte (+1 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Make button accessible by adding aria-label, aria-hidden to <svgs.. and aria-pressed to button - as this is a toggle button.

Added

Make button accessible by adding aria-label, aria-hidden to <svgs.. and aria-pressed to button - as this is a toggle button.

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16321 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 8/6/2025 **Status:** ✅ Merged **Merged:** 8/6/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/more-accessible-menu` --- ### 📝 Commits (4) - [`502a368`](https://github.com/open-webui/open-webui/commit/502a36869e6e4ed6791859a6d8eb78788f73e1eb) aria-hidden on icons to hide them from assistive technology - [`ba1e32f`](https://github.com/open-webui/open-webui/commit/ba1e32f60d96a710ca9595f6c147146c9ddcdc00) add aria-label to labelless button to enhance accessibility - [`9df790a`](https://github.com/open-webui/open-webui/commit/9df790a9f9c02910179f276ec55a6d452175fbde) make buttons DropdownMenuItems to make them accessible by keyboard, add handling of highContrastMode - [`52ef3e7`](https://github.com/open-webui/open-webui/commit/52ef3e74e6e78b0b106eb6bad928d1b2cd6052ba) add aria-labels and aria-pressed to enhance accessibility ### 📊 Changes **8 files changed** (+25 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/ModelSelector/ModelItem.svelte` (+1 -0) 📝 `src/lib/components/chat/ModelSelector/ModelItemMenu.svelte` (+11 -5) 📝 `src/lib/components/chat/ModelSelector/Selector.svelte` (+8 -2) 📝 `src/lib/components/icons/ChatBubbleOval.svelte` (+1 -0) 📝 `src/lib/components/icons/Eye.svelte` (+1 -0) 📝 `src/lib/components/icons/EyeSlash.svelte` (+1 -0) 📝 `src/lib/components/icons/Link.svelte` (+1 -0) 📝 `src/lib/components/icons/Search.svelte` (+1 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Make button accessible by adding `aria-label`, `aria-hidden` to `<svgs..` and `aria-pressed` to button - as this is a toggle button. ### Added - Make button accessible by adding `aria-label`, `aria-hidden` to `<svgs..` and `aria-pressed` to button - as this is a toggle button. ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos <img width="1869" height="190" alt="image" src="https://github.com/user-attachments/assets/6c66adfa-e73e-48d9-a1bc-ae30ac5fa8f4" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:14:07 -05:00

GiteaMirror closed this issue

2026-04-29 22:14:11 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47140