[PR #16067] [CLOSED] feat: prompt to delete shared link on archive chat if one exists #47068

New Issue

GiteaMirror · 2026-04-29T22:07:15-05:00

GiteaMirror commented

2026-04-29 22:07:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16067
Author: @silentoplayz
Created: 7/27/2025
Status: ❌ Closed

Base: dev ← Head: feat/archive-shared-chat-prompt

📝 Commits (2)

4c960f7 feat: archive shared chat prompt
3e8e8e4 fix: Remove confirmation on delete link

📊 Changes

3 files changed (+151 additions, -6 deletions)

View changed files

➕ src/lib/components/chat/ConfirmArchiveModal.svelte (+119 -0)
📝 src/lib/components/common/RichTextInput.svelte (+12 -4)
📝 src/lib/components/layout/Sidebar/ChatItem.svelte (+20 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request introduces a confirmation modal that appears when you attempt to archive a chat that has an active shared link. This modal provides you with the option to either keep or delete the existing share link before proceeding with the archiving process. This change is motivated by the need to prevent unintended exposure of chat content and to give you explicit control over your shared links, enhancing data privacy and content management.

Added

A confirmation modal that prompts you to either Keep or Delete a chat's existing share link when archiving.

Changed

The archiving process for chats with active shared links now includes a confirmation step, requiring your input before proceeding.
The UI of the confirmation modal has been designed in a way to mostly align with the existing design, ensuring a consistent user experience in both light and dark modes. This confirmation modal could still use some refactors by the maintainer if this PR gets merged.

Fixed

Fixed an error in RichTextInput.svelte that occurred when a chat was archived, preventing the Tiptap editor from being accessed after it was unmounted.

Security

Enhanced security by giving you explicit control over shared links when archiving chats, reducing the risk of unintended data exposure.

Additional Information

This feature was developed to address the potential privacy issue of shared links remaining active after a chat has been archived. The implementation ensures that you are aware of active share links and can manage them directly during the archiving process.
- This pull request resolves the issues described in the initial problem description, providing a more intuitive and secure user experience.
- Addresses https://github.com/open-webui/open-webui/issues/14761

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16067 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/27/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/archive-shared-chat-prompt` --- ### 📝 Commits (2) - [`4c960f7`](https://github.com/open-webui/open-webui/commit/4c960f73f86d474d2bc14867316a3258edd82b79) feat: archive shared chat prompt - [`3e8e8e4`](https://github.com/open-webui/open-webui/commit/3e8e8e4af98c75141c8d12d06e68f4806e52a26b) fix: Remove confirmation on delete link ### 📊 Changes **3 files changed** (+151 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `src/lib/components/chat/ConfirmArchiveModal.svelte` (+119 -0) 📝 `src/lib/components/common/RichTextInput.svelte` (+12 -4) 📝 `src/lib/components/layout/Sidebar/ChatItem.svelte` (+20 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request introduces a confirmation modal that appears when you attempt to archive a chat that has an active shared link. This modal provides you with the option to either keep or delete the existing share link before proceeding with the archiving process. This change is motivated by the need to prevent unintended exposure of chat content and to give you explicit control over your shared links, enhancing data privacy and content management. ### Added - A confirmation modal that prompts you to either `Keep` or `Delete` a chat's existing share link when archiving. ### Changed - The archiving process for chats with active shared links now includes a confirmation step, requiring your input before proceeding. - The UI of the confirmation modal has been designed in a way to mostly align with the existing design, ensuring a consistent user experience in both light and dark modes. **This confirmation modal could still use some refactors by the maintainer if this PR gets merged.** ### Fixed - Fixed an error in `RichTextInput.svelte` that occurred when a chat was archived, preventing the Tiptap editor from being accessed after it was unmounted. ### Security - Enhanced security by giving you explicit control over shared links when archiving chats, reducing the risk of unintended data exposure. --- ### Additional Information - This feature was developed to address the potential privacy issue of shared links remaining active after a chat has been archived. The implementation ensures that you are aware of active share links and can manage them directly during the archiving process. - This pull request resolves the issues described in the initial problem description, providing a more intuitive and secure user experience. - Addresses https://github.com/open-webui/open-webui/issues/14761 ### Screenshots or Videos <img width="606" height="278" alt="image" src="https://github.com/user-attachments/assets/262148d1-a0e6-44c1-8864-ea67bbd27921" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:07:15 -05:00

GiteaMirror closed this issue

2026-04-29 22:07:18 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47068