[PR #16063] [MERGED] fix(frontend): Ensure 'Her' theme is always a light theme #47067

New Issue

GiteaMirror · 2026-04-29T22:07:10-05:00

GiteaMirror commented

2026-04-29 22:07:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16063
Author: @silentoplayz
Created: 7/27/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @tjbck

Base: dev ← Head: fix-her-theme

📝 Commits (3)

c03741d fix(frontend): Ensure 'Her' theme is always a light theme
f1de837 fix: should fix the "breaking change"
694494a Revert "fix: should fix the "breaking change""

📊 Changes

2 files changed (+1 additions, -2 deletions)

View changed files

📝 src/app.html (+0 -1)
📝 src/lib/components/chat/Settings/General.svelte (+1 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request fixes a long-standing issue where the "Her" theme would incorrectly switch to dark mode after a user logs out and logs back into their account. The theme is now correctly and consistently applied as a light theme.

Changed

Updated src/app.html to remove the line that was incorrectly adding the dark class to the "Her" theme.
Updated src/lib/components/chat/Settings/General.svelte to ensure the light class is applied when the "Her" theme is selected.

Fixed

The "Her" theme now correctly persists as a light theme after logging out and back in.

Additional Information

This fix addresses a visual bug that was causing an inconsistent user experience for users of the "Her" theme.
Solves https://github.com/open-webui/open-webui/issues/14996

Breaking Changes

A "consequence" I've noticed from the changes made in this PR is that one of the "OI" text logos is now black, rather than white on the "Her" splash screen upon logging out of an account with the "Her" theme applied.

I'll admit, the splash screen isn't ideal in its current state, but that's not the scope of this fix.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16063 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/27/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-her-theme` --- ### 📝 Commits (3) - [`c03741d`](https://github.com/open-webui/open-webui/commit/c03741df9391a28a1a6921902219dc4f90ea8c63) fix(frontend): Ensure 'Her' theme is always a light theme - [`f1de837`](https://github.com/open-webui/open-webui/commit/f1de837fefec3e284a7c69af4850affb37f8045e) fix: should fix the "breaking change" - [`694494a`](https://github.com/open-webui/open-webui/commit/694494ad5ef3db3f200cf02c7cfbf7418369a8ba) Revert "fix: should fix the "breaking change"" ### 📊 Changes **2 files changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/app.html` (+0 -1) 📝 `src/lib/components/chat/Settings/General.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request fixes a long-standing issue where the "Her" theme would incorrectly switch to dark mode after a user logs out and logs back into their account. The theme is now correctly and consistently applied as a light theme. ### Changed - Updated `src/app.html` to remove the line that was incorrectly adding the dark class to the "Her" theme. - Updated `src/lib/components/chat/Settings/General.svelte` to ensure the light class is applied when the "Her" theme is selected. ### Fixed - The "Her" theme now correctly persists as a light theme after logging out and back in. ### Additional Information - This fix addresses a visual bug that was causing an inconsistent user experience for users of the "Her" theme. - Solves https://github.com/open-webui/open-webui/issues/14996 ### Breaking Changes - A "consequence" I've noticed from the changes made in this PR is that one of the "OI" text logos is now black, rather than white on the "Her" splash screen upon logging out of an account with the "Her" theme applied. ### I'll admit, the splash screen isn't ideal in its current state, but that's not the scope of this fix. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:07:10 -05:00

GiteaMirror closed this issue

2026-04-29 22:07:13 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47067