[PR #16061] [MERGED] fix: prevent error when autoscrolling in FloatingButtons #47066

New Issue

GiteaMirror · 2026-04-29T22:07:03-05:00

GiteaMirror commented

2026-04-29 22:07:03 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16061
Author: @silentoplayz
Created: 7/27/2025
Status: ✅ Merged
Merged: 7/30/2025
Merged by: @tjbck

Base: dev ← Head: fix/autoscrolling-in-FloatingButtons

📝 Commits (1)

1d85729 fix: prevent error when autoscrolling in FloatingButtons

📊 Changes

1 file changed (+34 additions, -11 deletions)

View changed files

📝 src/lib/components/chat/ContentRenderer/FloatingButtons.svelte (+34 -11)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request fixes a bug that caused the browser to spam TypeError and DOMException errors in the console when navigating to a new chat while a local model was generating a response in the "Ask" or "Explain" modal.

Changed

The askHandler and explainHandler functions in FloatingButtons.svelte now store the AbortController for the fetch request.
An onDestroy lifecycle hook has been added to FloatingButtons.svelte to abort the fetch request when the component is unmounted.
The try...catch blocks in askHandler and explainHandler have been updated to gracefully handle DOMException errors with the name AbortError.

Fixed

The application no longer spams the console with errors when navigating away from a chat while a local model is generating a response in the "Ask" or "Explain" modal.
The autoScroll function in FloatingButtons.svelte now checks if the responseContainer element exists before attempting to access its properties.

Additional Information

This change ensures that the application gracefully handles the unmounting of the "Ask" or "Explain" modal while a local model is generating a response.
Solves https://github.com/open-webui/open-webui/issues/16057

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16061 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/27/2025 **Status:** ✅ Merged **Merged:** 7/30/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/autoscrolling-in-FloatingButtons` --- ### 📝 Commits (1) - [`1d85729`](https://github.com/open-webui/open-webui/commit/1d85729b4ae7983312a6acf0e920df8baa22863f) fix: prevent error when autoscrolling in FloatingButtons ### 📊 Changes **1 file changed** (+34 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/ContentRenderer/FloatingButtons.svelte` (+34 -11) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request fixes a bug that caused the browser to spam `TypeError` and `DOMException` errors in the console when navigating to a new chat while a local model was generating a response in the "Ask" or "Explain" modal. ### Changed - The `askHandler` and `explainHandler` functions in `FloatingButtons.svelte` now store the `AbortController` for the `fetch` request. - An `onDestroy` lifecycle hook has been added to `FloatingButtons.svelte` to abort the `fetch` request when the component is unmounted. - The `try...catch` blocks in `askHandler` and `explainHandler` have been updated to gracefully handle `DOMException` errors with the name `AbortError`. ### Fixed - The application no longer spams the console with errors when navigating away from a chat while a local model is generating a response in the "Ask" or "Explain" modal. - The `autoScroll` function in `FloatingButtons.svelte` now checks if the `responseContainer` element exists before attempting to access its properties. --- ### Additional Information - This change ensures that the application gracefully handles the unmounting of the "Ask" or "Explain" modal while a local model is generating a response. - Solves https://github.com/open-webui/open-webui/issues/16057 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:07:03 -05:00

GiteaMirror closed this issue

2026-04-29 22:07:08 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#47066