[PR #15841] [CLOSED] fix: Avoid 404 response and handle the posibility that id is not included #47005

Closed
opened 2026-04-29 22:03:02 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15841
Author: @alvarellos
Created: 7/18/2025
Status: ❌ Closed

Base: dev ← Head: bugfix/id-check-requests-chat-id-tag-id


📝 Commits (1)

  • b4cd71d bugfix/ avoid 404 response and handle the posibility that id is not in the request

📊 Changes

2 files changed (+16 additions, -0 deletions)

View changed files

📝 src/lib/apis/chats/index.ts (+12 -0)
📝 src/lib/apis/index.ts (+4 -0)

📄 Description

…n the request

Pull Request Checklist

Discussion: https://github.com/open-webui/open-webui/discussions/15808

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Avoid response 404 checking if the id is missing.

Added

  • Error control

Changed

  • Error control to avoid 404 in some endpoints

Deprecated

  • Nothing is deprecated

Removed

  • Nothing has been removed. Only added.

Fixed

  • 404 errors will stop appearing when id is missing

Security

  • No control of such errors can lead to vulnerability issues.

Breaking Changes

  • No breaking changes found

Additional Information

  • Important to control and avoid this kind of errors which are displayed in the client side.

Screenshots or Videos

404 errros

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15841 **Author:** [@alvarellos](https://github.com/alvarellos) **Created:** 7/18/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `bugfix/id-check-requests-chat-id-tag-id` --- ### 📝 Commits (1) - [`b4cd71d`](https://github.com/open-webui/open-webui/commit/b4cd71d673e650bfa397810ab61370392167efe3) bugfix/ avoid 404 response and handle the posibility that id is not in the request ### 📊 Changes **2 files changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/chats/index.ts` (+12 -0) 📝 `src/lib/apis/index.ts` (+4 -0) </details> ### 📄 Description …n the request # Pull Request Checklist ### Discussion: https://github.com/open-webui/open-webui/discussions/15808 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Avoid response 404 checking if the id is missing. ### Added - Error control ### Changed - Error control to avoid 404 in some endpoints ### Deprecated - Nothing is deprecated ### Removed - Nothing has been removed. Only added. ### Fixed - 404 errors will stop appearing when id is missing ### Security - No control of such errors can lead to vulnerability issues. ### Breaking Changes - No breaking changes found --- ### Additional Information - Important to control and avoid this kind of errors which are displayed in the client side. ### Screenshots or Videos <img width="737" height="888" alt="404 errros" src="https://github.com/user-attachments/assets/c06446fe-484f-4607-89d8-549e83f102ec" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 22:03:02 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#47005