[PR #15797] [CLOSED] feat: show all knowledge collections #46992

New Issue

GiteaMirror · 2026-04-29T22:01:47-05:00

GiteaMirror commented

2026-04-29 22:01:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15797
Author: @chrispahm
Created: 7/16/2025
Status: ❌ Closed

Base: dev ← Head: fix-public-knowledge-collections

📝 Commits (2)

53f2092 feat: show all knowledge collections
f3c5ca1 i18n: Fix typo in de-DE translation

📊 Changes

11 files changed (+142 additions, -81 deletions)

View changed files

📝 src/lib/components/workspace/Knowledge.svelte (+32 -18)
📝 src/lib/components/workspace/Knowledge/KnowledgeBase.svelte (+97 -59)
📝 src/lib/components/workspace/Knowledge/KnowledgeBase/Files.svelte (+2 -1)
📝 src/lib/i18n/locales/de-DE/translation.json (+2 -1)
📝 src/lib/i18n/locales/es-ES/translation.json (+1 -0)
📝 src/lib/i18n/locales/fr-CA/translation.json (+1 -0)
📝 src/lib/i18n/locales/fr-FR/translation.json (+1 -0)
📝 src/lib/i18n/locales/it-IT/translation.json (+1 -0)
📝 src/lib/i18n/locales/nl-NL/translation.json (+1 -0)
📝 src/lib/stores/index.ts (+1 -0)
📝 src/routes/(app)/workspace/knowledge/+page.svelte (+3 -2)

📄 Description

Discussion: https://github.com/open-webui/open-webui/discussions/15315

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Added support for displaying all knowledge collections, including public ones that users have read-only access to, while maintaining proper write access controls for editing and management operations.

Added

New knowledgeList store to track all available knowledge collections
"Public" badge for knowledge collections that users can view but not edit
Read-only mode for knowledge base content when users lack write access
checkWriteAccess function to determine user permissions for knowledge collections
New translation key "Select a file to view" across all supported locales

Changed

Knowledge listing now shows both owned and publicly accessible collections
File upload and editing interfaces are conditionally disabled based on write access
Knowledge base editor switches to read-only mode for public collections
Access control button is only shown for collections with write access
File item components now accept a dismissible parameter to control delete functionality
Drag and drop functionality is only enabled for collections with write access

Deprecated

None

Removed

None

Fixed

None

Security

Proper access control implementation ensures users cannot modify knowledge collections they don't own
Read-only mode prevents unauthorized editing of public knowledge bases

Breaking Changes

None

Additional Information

This change enhances the knowledge management system by allowing users to discover and access public knowledge collections while maintaining security boundaries
The implementation preserves the existing user experience for owned collections while adding clear visual indicators for public access
All UI elements that require write permissions are appropriately disabled or hidden when viewing public collections

Screenshots or Videos

"Public" Badge for read-only collections
Edit / Delete UI elements are hidden for read-only collections
File contents of read-only collections are rendered as plain text instead of interactive editor

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15797 **Author:** [@chrispahm](https://github.com/chrispahm) **Created:** 7/16/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-public-knowledge-collections` --- ### 📝 Commits (2) - [`53f2092`](https://github.com/open-webui/open-webui/commit/53f2092bdcfc221fddc1ae665ea40069e078ea43) feat: show all knowledge collections - [`f3c5ca1`](https://github.com/open-webui/open-webui/commit/f3c5ca10d13a4441c03756fadf340b95e3ae5d1f) i18n: Fix typo in de-DE translation ### 📊 Changes **11 files changed** (+142 additions, -81 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Knowledge.svelte` (+32 -18) 📝 `src/lib/components/workspace/Knowledge/KnowledgeBase.svelte` (+97 -59) 📝 `src/lib/components/workspace/Knowledge/KnowledgeBase/Files.svelte` (+2 -1) 📝 `src/lib/i18n/locales/de-DE/translation.json` (+2 -1) 📝 `src/lib/i18n/locales/es-ES/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/fr-CA/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/fr-FR/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/it-IT/translation.json` (+1 -0) 📝 `src/lib/i18n/locales/nl-NL/translation.json` (+1 -0) 📝 `src/lib/stores/index.ts` (+1 -0) 📝 `src/routes/(app)/workspace/knowledge/+page.svelte` (+3 -2) </details> ### 📄 Description Discussion: https://github.com/open-webui/open-webui/discussions/15315 # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Added support for displaying all knowledge collections, including public ones that users have read-only access to, while maintaining proper write access controls for editing and management operations. ### Added - New `knowledgeList` store to track all available knowledge collections - "Public" badge for knowledge collections that users can view but not edit - Read-only mode for knowledge base content when users lack write access - `checkWriteAccess` function to determine user permissions for knowledge collections - New translation key `"Select a file to view"` across all supported locales ### Changed - Knowledge listing now shows both owned and publicly accessible collections - File upload and editing interfaces are conditionally disabled based on write access - Knowledge base editor switches to read-only mode for public collections - Access control button is only shown for collections with write access - File item components now accept a `dismissible` parameter to control delete functionality - Drag and drop functionality is only enabled for collections with write access ### Deprecated - None ### Removed - None ### Fixed - None ### Security - Proper access control implementation ensures users cannot modify knowledge collections they don't own - Read-only mode prevents unauthorized editing of public knowledge bases ### Breaking Changes - None --- ### Additional Information - This change enhances the knowledge management system by allowing users to discover and access public knowledge collections while maintaining security boundaries - The implementation preserves the existing user experience for owned collections while adding clear visual indicators for public access - All UI elements that require write permissions are appropriately disabled or hidden when viewing public collections ### Screenshots or Videos - "Public" Badge for read-only collections <img width="878" height="338" alt="image" src="https://github.com/user-attachments/assets/e15fef56-01b6-472e-9a9b-66a2c8205e92" /> - Edit / Delete UI elements are hidden for read-only collections <img width="1224" height="253" alt="image" src="https://github.com/user-attachments/assets/9ead977c-d08a-4eec-ba75-ee7eb175a48b" /> - File contents of read-only collections are rendered as plain text instead of interactive editor <img width="1219" height="576" alt="image" src="https://github.com/user-attachments/assets/ca69f881-260c-454b-96aa-0d13262558e1" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 22:01:47 -05:00

GiteaMirror closed this issue

2026-04-29 22:01:51 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46992