[PR #15632] [MERGED] fix: don't over quote forwarded headers #46944

New Issue

GiteaMirror · 2026-04-29T21:57:27-05:00

GiteaMirror commented

2026-04-29 21:57:27 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15632
Author: @athoik
Created: 7/10/2025
Status: ✅ Merged
Merged: 7/11/2025
Merged by: @tjbck

Base: dev ← Head: quote

📝 Commits (1)

9675817 fix: don't over quote forwarded headers

📊 Changes

5 files changed (+84 additions, -84 deletions)

View changed files

📝 backend/open_webui/retrieval/utils.py (+12 -12)
📝 backend/open_webui/routers/audio.py (+4 -4)
📝 backend/open_webui/routers/images.py (+4 -4)
📝 backend/open_webui/routers/ollama.py (+36 -36)
📝 backend/open_webui/routers/openai.py (+28 -28)

📄 Description

Changelog Entry

Description

Fix introduced on #15035 is over quoting headers.

Eg mails instead of user@example.com shown as user%40example.com Eg names instead of First Last shown as First%20Last

Also we are spending some time quoting ids and roles without required.

Keep quote only on user name, initially had problem based on the discussion https://github.com/open-webui/open-webui/discussions/14391

Also add space in safe characters, in order remove %20 from names.

Breaking Changes

BREAKING CHANGE: None

Screenshots or Videos

464393710-8edb3b7c-037e-4a36-ab88-a9290b27b76c

This commit will fix wrong %20 inserted on names and %40 insertead on emails.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15632 **Author:** [@athoik](https://github.com/athoik) **Created:** 7/10/2025 **Status:** ✅ Merged **Merged:** 7/11/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `quote` --- ### 📝 Commits (1) - [`9675817`](https://github.com/open-webui/open-webui/commit/96758176cc6cd80a7bf9ba198e5d6cd2ffa39664) fix: don't over quote forwarded headers ### 📊 Changes **5 files changed** (+84 additions, -84 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/utils.py` (+12 -12) 📝 `backend/open_webui/routers/audio.py` (+4 -4) 📝 `backend/open_webui/routers/images.py` (+4 -4) 📝 `backend/open_webui/routers/ollama.py` (+36 -36) 📝 `backend/open_webui/routers/openai.py` (+28 -28) </details> ### 📄 Description # Changelog Entry ### Description Fix introduced on #15035 is over quoting headers. Eg mails instead of user@example.com shown as user%40example.com Eg names instead of First Last shown as First%20Last Also we are spending some time quoting ids and roles without required. Keep quote only on user name, initially had problem based on the discussion https://github.com/open-webui/open-webui/discussions/14391 Also add space in safe characters, in order remove %20 from names. ### Breaking Changes - **BREAKING CHANGE**: None --- ### Screenshots or Videos <img width="285" height="342" alt="464393710-8edb3b7c-037e-4a36-ab88-a9290b27b76c" src="https://github.com/user-attachments/assets/2b6c1051-e826-4215-98e6-55525d229d2e" /> This commit will fix wrong %20 inserted on names and %40 insertead on emails. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 21:57:27 -05:00

GiteaMirror closed this issue

2026-04-29 21:57:28 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46944