[PR #14900] [MERGED] fix: prevent redundant documents in expanded citation list #46684

New Issue

GiteaMirror · 2026-04-29T21:33:40-05:00

GiteaMirror commented

2026-04-29 21:33:40 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14900
Author: @silentoplayz
Created: 6/11/2025
Status: ✅ Merged
Merged: 6/11/2025
Merged by: @tjbck

Base: dev ← Head: fix-references

📝 Commits (1)

8e60174 fix: prevent redundant documents in expanded citation list

📊 Changes

1 file changed (+2 additions, -3 deletions)

View changed files

📝 src/lib/components/chat/Messages/Citations.svelte (+2 -3)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed an issue in the citation display where clicking "and X more" would incorrectly include and repeat the first two already-visible document references in the expanded list. The expanded list now correctly shows only the additional referenced documents.

Changed

Modified src/lib/components/chat/Messages/Citations.svelte to use citations.slice(2) when rendering the collapsed citations within the Collapsible component's slot="content". This ensures only documents beyond the initial two are displayed in the expanded list.
Adjusted the id attribute and the displayed numerical index for citations within the expanded list to maintain correct numbering.

Fixed

Resolved a UI bug where the "and X more" citation expansion would show 2 more documents than intended by including the first two documents again.

Additional Information

This change improves the user experience by providing an accurate and non-redundant list of additional document references when expanding the citation section.
The previous behavior led to displaying N+2 documents when N was expected, where N was the number of "more" documents. This has been corrected.

Screenshots or Videos

Before:

After:

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14900 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/11/2025 **Status:** ✅ Merged **Merged:** 6/11/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-references` --- ### 📝 Commits (1) - [`8e60174`](https://github.com/open-webui/open-webui/commit/8e60174e0d02d42883ca02b9f9ec0e84c3574159) fix: prevent redundant documents in expanded citation list ### 📊 Changes **1 file changed** (+2 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/Citations.svelte` (+2 -3) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed an issue in the citation display where clicking "and X more" would incorrectly include and repeat the first two already-visible document references in the expanded list. The expanded list now correctly shows only the additional referenced documents. ### Changed - Modified `src/lib/components/chat/Messages/Citations.svelte` to use `citations.slice(2)` when rendering the collapsed citations within the `Collapsible` component's `slot="content"`. This ensures only documents beyond the initial two are displayed in the expanded list. - Adjusted the `id` attribute and the displayed numerical index for citations within the expanded list to maintain correct numbering. ### Fixed - Resolved a UI bug where the "and X more" citation expansion would show 2 more documents than intended by including the first two documents again. --- ### Additional Information - This change improves the user experience by providing an accurate and non-redundant list of additional document references when expanding the citation section. - The previous behavior led to displaying `N+2` documents when `N` was expected, where `N` was the number of "more" documents. This has been corrected. ### Screenshots or Videos **Before:** ![image](https://github.com/user-attachments/assets/9cc2b5b8-6581-4e9a-bfdf-84c1746dff97) **After:** ![image](https://github.com/user-attachments/assets/05f692cd-c209-4ef7-96fb-30376ccb1972) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 21:33:40 -05:00

GiteaMirror closed this issue

2026-04-29 21:33:41 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46684