[PR #14770] [MERGED] fix: remove newline from Pending User Overlay Title input field #46632

Closed
opened 2026-04-29 21:30:27 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14770
Author: @silentoplayz
Created: 6/8/2025
Status: Merged
Merged: 6/8/2025
Merged by: @tjbck

Base: devHead: small-fix


📝 Commits (1)

📊 Changes

1 file changed (+0 additions, -1 deletions)

View changed files

📝 src/lib/components/admin/Settings/General.svelte (+0 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Removed the rows={2} attribute from the Pending User Overlay Title textarea to reduce its initial vertical height. This change addresses the perception of an "extra new line" or excessive vertical spacing for this input field, making the layout more compact.

Changed

  • Modified the Textarea component for the 'Pending User Overlay Title' by removing its explicit rows attribute. This causes the textarea to default to an initial height of one line (or the component's inherent default), reducing the vertical space it occupies.

Removed

  • The rows attribute with a value of 2 from the <Textarea> component associated with the PENDING_USER_OVERLAY_TITLE binding.

Fixed

  • Improved the visual alignment and reduced unnecessary vertical spacing for the 'Pending User Overlay Title' input field in the admin settings.

Additional Information

  • This adjustment provides a cleaner and more compact user interface in the General settings section without impacting functionality. The textarea will continue to expand dynamically as more text is entered by the user.

Screenshots or Videos

Before:
image
After:
image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14770 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/8/2025 **Status:** ✅ Merged **Merged:** 6/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `small-fix` --- ### 📝 Commits (1) - [`92c7549`](https://github.com/open-webui/open-webui/commit/92c7549b0649f0e76932bbbd2e2dd43826e280b1) fix: remove newline ### 📊 Changes **1 file changed** (+0 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Settings/General.svelte` (+0 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Removed the `rows={2}` attribute from the `Pending User Overlay Title` textarea to reduce its initial vertical height. This change addresses the perception of an "extra new line" or excessive vertical spacing for this input field, making the layout more compact. ### Changed - Modified the `Textarea` component for the 'Pending User Overlay Title' by removing its explicit `rows` attribute. This causes the textarea to default to an initial height of one line (or the component's inherent default), reducing the vertical space it occupies. ### Removed - The `rows` attribute with a value of `2` from the `<Textarea>` component associated with the `PENDING_USER_OVERLAY_TITLE` binding. ### Fixed - Improved the visual alignment and reduced unnecessary vertical spacing for the 'Pending User Overlay Title' input field in the admin settings. --- ### Additional Information - This adjustment provides a cleaner and more compact user interface in the General settings section without impacting functionality. The textarea will continue to expand dynamically as more text is entered by the user. ### Screenshots or Videos **Before:** ![image](https://github.com/user-attachments/assets/b27c0971-71aa-4502-aa9f-fb407ea5e816) **After:** ![image](https://github.com/user-attachments/assets/80d100f7-76b7-4e57-a6da-83467c04af7d) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 21:30:27 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#46632