[PR #14617] [CLOSED] feat: Implement URL-Based Tabs for Admin Users & Evaluations Pages #46571

New Issue

GiteaMirror · 2026-04-29T21:26:13-05:00

GiteaMirror commented

2026-04-29 21:26:13 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14617
Author: @silentoplayz
Created: 6/3/2025
Status: ❌ Closed

Base: dev ← Head: route-for-settings-tabs

📝 Commits (1)

15bce43 feat: route for users and evaluations tabs

📊 Changes

9 files changed (+62 additions, -12 deletions)

View changed files

📝 src/lib/components/admin/Evaluations.svelte (+12 -4)
📝 src/lib/components/admin/Users.svelte (+10 -3)
📝 src/routes/(app)/admin/+layout.svelte (+8 -5)
📝 src/routes/(app)/admin/evaluations/+page.svelte (+6 -0)
➕ src/routes/(app)/admin/evaluations/feedbacks/+page.svelte (+5 -0)
➕ src/routes/(app)/admin/evaluations/leaderboard/+page.svelte (+5 -0)
📝 src/routes/(app)/admin/users/+page.svelte (+6 -0)
➕ src/routes/(app)/admin/users/groups/+page.svelte (+5 -0)
➕ src/routes/(app)/admin/users/overview/+page.svelte (+5 -0)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Implemented URL-based routing for tabs within the Admin "Users" and "Evaluations" pages. This allows for direct navigation to specific tabs via URL and ensures selected tabs persist during hot reloading in development.
Also includes a fix for navigation highlighting in the Admin layout.
My PR is inspired by THIS related PR and reuses very much of the same code. - https://github.com/open-webui/open-webui/pull/14555

Added

src/routes/(app)/admin/users/overview/+page.svelte: New file to define the /admin/users/overview route.
src/routes/(app)/admin/users/groups/+page.svelte: New file to define the /admin/users/groups route.
src/routes/(app)/admin/evaluations/leaderboard/+page.svelte: New file to define the /admin/evaluations/leaderboard route.
src/routes/(app)/admin/evaluations/feedbacks/+page.svelte: New file to define the /admin/evaluations/feedbacks route.

Changed

src/lib/components/admin/Users.svelte:
- Updated tab selection logic to derive the selectedTab from the URL pathname using $page.url.pathname.
- Changed tab button on:click handlers to use goto('/admin/users/tab-name') for URL navigation instead of directly setting selectedTab.
- Added import { page } from '$app/stores';.
src/routes/(app)/admin/users/+page.svelte:
- Added an onMount hook to redirect from /admin/users to /admin/users/overview by default.
- Added import { goto, onMount } from '$app/navigation';.
src/lib/components/admin/Evaluations.svelte:
- Updated tab selection logic to derive the selectedTab from the URL pathname using $page.url.pathname.
- Changed tab button on:click handlers to use goto('/admin/evaluations/tab-name') for URL navigation instead of directly setting selectedTab.
- Added import { goto } from '$app/navigation'; and import { page } from '$app/stores';.
src/routes/(app)/admin/evaluations/+page.svelte:
- Added an onMount hook to redirect from /admin/evaluations to /admin/evaluations/leaderboard by default.
- Added import { goto, onMount } from 'svelte';.
src/routes/(app)/admin/+layout.svelte:
- Updated the 'Users' navigation link href from /admin to /admin/users to reflect the new routing structure.
- Refined the highlighting logic for 'Users', 'Evaluations', 'Functions', and 'Settings' navigation links. Now uses startsWith for path matching (e.g., $page.url.pathname.startsWith('/admin/users')) to correctly highlight parent links when on any of their sub-tabs. Also added specific handling for /admin for the 'Users' link.

Fixed

Admin panel main navigation links (Users, Evaluations, Functions, Settings) now correctly highlight based on the current URL and its sub-paths.
Fixed the default redirection for the base /admin path to now correctly land on /admin/users/overview.

Breaking Changes

This is an enhancement and not expected to break existing functionality, as old /admin paths redirect gracefully.

Additional Information

This change significantly improves the development experience by ensuring that the selected tab persists during hot module reloading (HMR), as the tab state is now driven by the URL.
It also enables direct linking to specific tabs within the "Users" and "Evaluations" sections (e.g., /admin/users/groups, /admin/evaluations/feedbacks).

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14617 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/3/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `route-for-settings-tabs` --- ### 📝 Commits (1) - [`15bce43`](https://github.com/open-webui/open-webui/commit/15bce43e7d953a8e931c1ef55801feaf6062834e) feat: route for users and evaluations tabs ### 📊 Changes **9 files changed** (+62 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/admin/Evaluations.svelte` (+12 -4) 📝 `src/lib/components/admin/Users.svelte` (+10 -3) 📝 `src/routes/(app)/admin/+layout.svelte` (+8 -5) 📝 `src/routes/(app)/admin/evaluations/+page.svelte` (+6 -0) ➕ `src/routes/(app)/admin/evaluations/feedbacks/+page.svelte` (+5 -0) ➕ `src/routes/(app)/admin/evaluations/leaderboard/+page.svelte` (+5 -0) 📝 `src/routes/(app)/admin/users/+page.svelte` (+6 -0) ➕ `src/routes/(app)/admin/users/groups/+page.svelte` (+5 -0) ➕ `src/routes/(app)/admin/users/overview/+page.svelte` (+5 -0) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Implemented URL-based routing for tabs within the Admin "Users" and "Evaluations" pages. This allows for direct navigation to specific tabs via URL and ensures selected tabs persist during hot reloading in development. - Also includes a fix for navigation highlighting in the Admin layout. - My PR is inspired by **THIS** related PR and reuses very much of the same code. - https://github.com/open-webui/open-webui/pull/14555 ### Added - `src/routes/(app)/admin/users/overview/+page.svelte`: New file to define the `/admin/users/overview` route. - `src/routes/(app)/admin/users/groups/+page.svelte`: New file to define the `/admin/users/groups` route. - `src/routes/(app)/admin/evaluations/leaderboard/+page.svelte`: New file to define the `/admin/evaluations/leaderboard` route. - `src/routes/(app)/admin/evaluations/feedbacks/+page.svelte`: New file to define the `/admin/evaluations/feedbacks` route. ### Changed - `src/lib/components/admin/Users.svelte`: - Updated tab selection logic to derive the `selectedTab` from the URL pathname using `$page.url.pathname`. - Changed tab button `on:click` handlers to use `goto('/admin/users/tab-name')` for URL navigation instead of directly setting `selectedTab`. - Added `import { page } from '$app/stores';`. - `src/routes/(app)/admin/users/+page.svelte`: - Added an `onMount` hook to redirect from `/admin/users` to `/admin/users/overview` by default. - Added `import { goto, onMount } from '$app/navigation';`. - `src/lib/components/admin/Evaluations.svelte`: - Updated tab selection logic to derive the `selectedTab` from the URL pathname using `$page.url.pathname`. - Changed tab button `on:click` handlers to use `goto('/admin/evaluations/tab-name')` for URL navigation instead of directly setting `selectedTab`. - Added `import { goto } from '$app/navigation';` and `import { page } from '$app/stores';`. - `src/routes/(app)/admin/evaluations/+page.svelte`: - Added an `onMount` hook to redirect from `/admin/evaluations` to `/admin/evaluations/leaderboard` by default. - Added `import { goto, onMount } from 'svelte';`. - `src/routes/(app)/admin/+layout.svelte`: - Updated the 'Users' navigation link `href` from `/admin` to `/admin/users` to reflect the new routing structure. - Refined the highlighting logic for 'Users', 'Evaluations', 'Functions', and 'Settings' navigation links. Now uses `startsWith` for path matching (e.g., `$page.url.pathname.startsWith('/admin/users')`) to correctly highlight parent links when on any of their sub-tabs. Also added specific handling for `/admin` for the 'Users' link. ### Fixed - Admin panel main navigation links (Users, Evaluations, Functions, Settings) now correctly highlight based on the current URL and its sub-paths. - Fixed the default redirection for the base `/admin` path to now correctly land on `/admin/users/overview`. ### Breaking Changes This is an enhancement and not expected to break existing functionality, as old `/admin` paths redirect gracefully. --- ### Additional Information - This change significantly improves the development experience by ensuring that the selected tab persists during hot module reloading (HMR), as the tab state is now driven by the URL. - It also enables direct linking to specific tabs within the "Users" and "Evaluations" sections (e.g., `/admin/users/groups`, `/admin/evaluations/feedbacks`). ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 21:26:13 -05:00

GiteaMirror closed this issue

2026-04-29 21:26:16 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46571