[PR #14559] [CLOSED] fix utils.py Web Search Vector Retrieval #46551

New Issue

GiteaMirror · 2026-04-29T21:24:32-05:00

GiteaMirror commented

2026-04-29 21:24:32 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14559
Author: @PVBLIC-F
Created: 5/31/2025
Status: ❌ Closed

Base: dev ← Head: fix/utils

📝 Commits (2)

3acd737 Update utils.py
2f3658d Update utils.py

📊 Changes

1 file changed (+340 additions, -70 deletions)

View changed files

📝 backend/open_webui/retrieval/utils.py (+340 -70)

📄 Description

Vector database queries occurred too quickly after document insertion , before indexing completed in services like Pinecone, leading to inconsistent retrieval behavior.

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Logic Flow Bug: Web search results were successfully fetched from external APIs (Tavily, Exa) and embedded into the vector database, but the embedded vectors were never retrieved during LLM response generation. This caused responses to lack current web information despite successful web searches.
Race Condition: Vector database queries occurred too quickly after document insertion, before indexing completed in services like Pinecone, leading to inconsistent retrieval behavior.

Added

Auto-detection: Identifies web search collections by "web-search-" prefix
Exponential backoff: 500ms to 2s intervals with smart timeout (15s for web search)
Stabilization logic: For unknown counts, waits for 2 consecutive stable checks
Performance: Averages 1.8s completion time

Changed

[List any changes, updates, refactorings, or optimizations]

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

[List any removed features, files, or functionalities]

Fixed

Logic Flow Fix in get_sources_from_files
Problem: Faulty elif condition prevented web search files from vector retrieval
Change: Modified conditional logic to ensure web search collections flow through vector pipeline
Impact: Web search files now properly reach vector database operations
Race Condition Resolution
Problem: Vector queries happened too quickly after insertion (0.9s), before indexing completed
Change: Replaced blind retry loops with intelligent waiting mechanisms
Impact: Consistent 100% document retrieval vs previous timeouts

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

[Insert any additional context, notes, or explanations for the changes]
- [Reference any related issues, commits, or other relevant information]

Screenshots or Videos

[Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14559 **Author:** [@PVBLIC-F](https://github.com/PVBLIC-F) **Created:** 5/31/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/utils` --- ### 📝 Commits (2) - [`3acd737`](https://github.com/open-webui/open-webui/commit/3acd737e4d95e105db13f2eb4ba20bdb696e9bca) Update utils.py - [`2f3658d`](https://github.com/open-webui/open-webui/commit/2f3658d52a2ce50751929f02f48f48bb26182796) Update utils.py ### 📊 Changes **1 file changed** (+340 additions, -70 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/utils.py` (+340 -70) </details> ### 📄 Description Vector database queries occurred too quickly after document insertion , before indexing completed in services like Pinecone, leading to inconsistent retrieval behavior. # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [ ] **Target branch:** Please verify that the pull request targets the `dev` branch. - [ ] **Description:** Provide a concise description of the changes made in this pull request. - [ ] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests to validate the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Logic Flow Bug: Web search results were successfully fetched from external APIs (Tavily, Exa) and embedded into the vector database, but the embedded vectors were never retrieved during LLM response generation. This caused responses to lack current web information despite successful web searches. - Race Condition: Vector database queries occurred too quickly after document insertion, before indexing completed in services like Pinecone, leading to inconsistent retrieval behavior. ### Added - Auto-detection: Identifies web search collections by "web-search-" prefix - Exponential backoff: 500ms to 2s intervals with smart timeout (15s for web search) - Stabilization logic: For unknown counts, waits for 2 consecutive stable checks - Performance: Averages 1.8s completion time ### Changed - [List any changes, updates, refactorings, or optimizations] ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - **Logic Flow Fix in get_sources_from_files** Problem: Faulty elif condition prevented web search files from vector retrieval Change: Modified conditional logic to ensure web search collections flow through vector pipeline Impact: Web search files now properly reach vector database operations - **Race Condition Resolution** Problem: Vector queries happened too quickly after insertion (0.9s), before indexing completed Change: Replaced blind retry loops with intelligent waiting mechanisms Impact: Consistent 100% document retrieval vs previous timeouts ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - [Insert any additional context, notes, or explanations for the changes] - [Reference any related issues, commits, or other relevant information] ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 21:24:32 -05:00

GiteaMirror closed this issue

2026-04-29 21:24:34 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46551