[PR #14153] [CLOSED] chore: Cleanup of low-risk code smells flagged by SonarQube scan #46450

Closed
opened 2026-04-29 21:16:30 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14153
Author: @NotYuSheng
Created: 5/22/2025
Status: Closed

Base: devHead: chore-cleanup


📝 Commits (10+)

📊 Changes

13 files changed (+3 additions, -30 deletions)

View changed files

📝 backend/open_webui/main.py (+0 -2)
📝 backend/open_webui/migrations/versions/1af9b942657b_migrate_tags.py (+0 -1)
📝 backend/open_webui/models/models.py (+0 -3)
📝 backend/open_webui/models/users.py (+0 -1)
📝 backend/open_webui/retrieval/models/colbert.py (+0 -1)
📝 backend/open_webui/retrieval/utils.py (+0 -2)
📝 backend/open_webui/retrieval/vector/dbs/chroma.py (+0 -1)
📝 backend/open_webui/routers/files.py (+1 -1)
📝 backend/open_webui/routers/knowledge.py (+0 -4)
📝 backend/open_webui/static/assets/pdf-style.css (+0 -5)
📝 backend/open_webui/utils/chat.py (+0 -1)
📝 src/app.html (+2 -0)
📝 static/themes/rosepine-dawn.css (+0 -8)

📄 Description

Changelog Entry

  • Removed redundant pass statements
  • Remove duplicate content in css files
  • Added missing alt attributes to <img> tags for improved accessibility

Description

  • SonarQube scan, Code Smell clean ups

Added

  • NIL

Changed

  • NIL

Deprecated

  • NIL

Removed

  • NIL

Fixed

  • NIL

Security

  • NIL

Breaking Changes

  • BREAKING CHANGE: NIL

Additional Information

  • NIL

Screenshots or Videos

  • NIL

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14153 **Author:** [@NotYuSheng](https://github.com/NotYuSheng) **Created:** 5/22/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `chore-cleanup` --- ### 📝 Commits (10+) - [`f50b81b`](https://github.com/open-webui/open-webui/commit/f50b81bdcac6c7c7c5404f2d0af24b77428cbd73) Merge pull request #1 from open-webui/main - [`4e6f476`](https://github.com/open-webui/open-webui/commit/4e6f476705496f5326ef264d2321a48e07834ab4) clean up - [`42b3489`](https://github.com/open-webui/open-webui/commit/42b348928d9c4f1c89439480f0daeb4d7c0c09e9) Update main.py - [`13c51e1`](https://github.com/open-webui/open-webui/commit/13c51e18a4ba6fa1d8b251eaceb5b008238769bd) Update pdf-style.css - [`d87edf9`](https://github.com/open-webui/open-webui/commit/d87edf91c22be3e2de8954901fe67ab1746aa232) Update 1af9b942657b_migrate_tags.py - [`facb7fc`](https://github.com/open-webui/open-webui/commit/facb7fcd76e788b4db891f562b16947c647560bb) Update knowledge.py - [`a828b14`](https://github.com/open-webui/open-webui/commit/a828b14b7d4218f9de3460d45631e16c4bc4e255) Update knowledge.py - [`bc82168`](https://github.com/open-webui/open-webui/commit/bc821685594c172120e48c75afb79a9bbdf86f28) Update models.py - [`ceb8a40`](https://github.com/open-webui/open-webui/commit/ceb8a4063954dcbea1dc018eaca4775275101f51) Update users.py - [`e94baf6`](https://github.com/open-webui/open-webui/commit/e94baf631a9d96f0bc439409215774d5c5ce3675) Update colbert.py ### 📊 Changes **13 files changed** (+3 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/main.py` (+0 -2) 📝 `backend/open_webui/migrations/versions/1af9b942657b_migrate_tags.py` (+0 -1) 📝 `backend/open_webui/models/models.py` (+0 -3) 📝 `backend/open_webui/models/users.py` (+0 -1) 📝 `backend/open_webui/retrieval/models/colbert.py` (+0 -1) 📝 `backend/open_webui/retrieval/utils.py` (+0 -2) 📝 `backend/open_webui/retrieval/vector/dbs/chroma.py` (+0 -1) 📝 `backend/open_webui/routers/files.py` (+1 -1) 📝 `backend/open_webui/routers/knowledge.py` (+0 -4) 📝 `backend/open_webui/static/assets/pdf-style.css` (+0 -5) 📝 `backend/open_webui/utils/chat.py` (+0 -1) 📝 `src/app.html` (+2 -0) 📝 `static/themes/rosepine-dawn.css` (+0 -8) </details> ### 📄 Description # Changelog Entry - Removed redundant `pass` statements - Remove duplicate content in css files - Added missing `alt` attributes to `<img>` tags for improved accessibility ### Description - SonarQube scan, Code Smell clean ups ### Added - NIL ### Changed - NIL ### Deprecated - NIL ### Removed - NIL ### Fixed - NIL ### Security - NIL ### Breaking Changes - **BREAKING CHANGE**: NIL --- ### Additional Information - NIL ### Screenshots or Videos - NIL ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 21:16:30 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#46450