[PR #13883] [MERGED] Fix: Unintentional toggling of model status on the workspace page. #46370

New Issue

GiteaMirror · 2026-04-29T21:09:09-05:00

GiteaMirror commented

2026-04-29 21:09:09 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13883
Author: @tremlin
Created: 5/14/2025
Status: ✅ Merged
Merged: 5/14/2025
Merged by: @tjbck

Base: dev ← Head: fix-workspace-model-unintended-toggle

📝 Commits (1)

6b6ce36 fix: add unique key to model list to avoid state confusion when filtering

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/lib/components/workspace/Models.svelte (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fix a bug that caused the models' activation status to be toggled unintentionally and randomly when using the model search bar.

Added

Changed

Deprecated

Removed

Fixed

Fix a bug that caused the models' activation status to be toggled unintentionally and randomly when using the model search bar.

Security

Breaking Changes

Additional Information

When using the search bar (and thus changing the filtered model list), Svelte reused the same DOM containers for different models. This triggered the onchange event of the Switch component when an inactive model was replaced in the list by an active one and vice versa, resulting in the unintended toggling of the activation status of models. The provided fix ties the DOM container to the model, eliminating any confusion about the state.

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13883 **Author:** [@tremlin](https://github.com/tremlin) **Created:** 5/14/2025 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-workspace-model-unintended-toggle` --- ### 📝 Commits (1) - [`6b6ce36`](https://github.com/open-webui/open-webui/commit/6b6ce36c9636a09b75d3a3db623c25668f211932) fix: add unique key to model list to avoid state confusion when filtering ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Models.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fix a bug that caused the models' activation status to be toggled unintentionally and randomly when using the model search bar. ### Added ### Changed ### Deprecated ### Removed ### Fixed - Fix a bug that caused the models' activation status to be toggled unintentionally and randomly when using the model search bar. ### Security ### Breaking Changes --- ### Additional Information When using the search bar (and thus changing the filtered model list), Svelte reused the same DOM containers for different models. This triggered the `onchange` event of the `Switch` component when an inactive model was replaced in the list by an active one and vice versa, resulting in the unintended toggling of the activation status of models. The provided fix ties the DOM container to the model, eliminating any confusion about the state. ### Screenshots or Videos ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 21:09:09 -05:00

GiteaMirror closed this issue

2026-04-29 21:09:10 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#46370