[PR #13703] [MERGED] fix: Add SharePoint tenant ID to OneDrive settings #46314

Closed
opened 2026-04-29 21:04:10 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/13703
Author: @hurxxxx
Created: 5/8/2025
Status: Merged
Merged: 5/8/2025
Merged by: @tjbck

Base: devHead: fix/onedrive-org-picker-error


📝 Commits (1)

  • 4ca0ea1 Add SharePoint tenant ID to OneDrive settings

📊 Changes

3 files changed (+19 additions, -3 deletions)

View changed files

📝 backend/open_webui/config.py (+5 -0)
📝 backend/open_webui/main.py (+3 -0)
📝 src/lib/utils/onedrive-file-picker.ts (+11 -3)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Changed

  • Users in single-tenant organizations must add the ONEDRIVE_SHAREPOINT_TENANT_ID setting to their .env file.
  • Updated onedrive-file-picker.ts to handle logic when ONEDRIVE_SHAREPOINT_TENANT_ID is set.

Screenshots or Videos

Error message when the tenant ID is not set
image

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/13703 **Author:** [@hurxxxx](https://github.com/hurxxxx) **Created:** 5/8/2025 **Status:** ✅ Merged **Merged:** 5/8/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/onedrive-org-picker-error` --- ### 📝 Commits (1) - [`4ca0ea1`](https://github.com/open-webui/open-webui/commit/4ca0ea1e55b81f7ba29f4adf288ebb89c8cc4da6) Add SharePoint tenant ID to OneDrive settings ### 📊 Changes **3 files changed** (+19 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/config.py` (+5 -0) 📝 `backend/open_webui/main.py` (+3 -0) 📝 `src/lib/utils/onedrive-file-picker.ts` (+11 -3) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description * When an organization uses a single tenant in SharePoint, the tenant ID is required in the `authority` endpoint of `msalParams`. * Added the `ONEDRIVE_SHAREPOINT_TENANT_ID` environment variable to allow single-tenant organizations to configure their tenant ID and use the OneDrive file picker. * #13635 * https://learn.microsoft.com/en-us/entra/identity-platform/msal-client-application-configuration ### Changed * Users in single-tenant organizations must add the ONEDRIVE_SHAREPOINT_TENANT_ID setting to their .env file. * Updated onedrive-file-picker.ts to handle logic when ONEDRIVE_SHAREPOINT_TENANT_ID is set. ### Screenshots or Videos Error message when the tenant ID is not set ![image](https://github.com/user-attachments/assets/b4cee3b7-0673-4a2a-8c9e-341360af0115) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-29 21:04:10 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#46314