Warning: This PR fixes the ability for users to create webhooks, which can be dangrous under certain conditions! This is known as an SSRF vulnerability. In this particular case the impact is very limited, but it is still classified as a security vulnerability. Please get in touch for more information.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
Fixed a bug that caused user notification webhooks to never be sent
Added
Changed
Deprecated
Removed
Fixed
Fixed user notification webhooks not being sent due to incorrect type check
Security
Warning: This PR fixes the ability for users to create webhooks, which can be dangrous under certain conditions! This is known as an SSRF vulnerability. In this particular case the impact is very limited, but it is still classified as a security vulnerability. Please get in touch for more information.
Breaking Changes
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the CONTRIBUTOR_LICENSE_AGREEMENT, and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/13258
**Author:** [@choket](https://github.com/choket)
**Created:** 4/27/2025
**Status:** ✅ Merged
**Merged:** 4/28/2025
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `dev`
---
### 📝 Commits (1)
- [`8a9de0a`](https://github.com/open-webui/open-webui/commit/8a9de0a62f58daa72e7d19798dfd5bc429eafa6f) Fix bug that never triggers user notification webhooks
### 📊 Changes
**1 file changed** (+2 additions, -2 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/utils/middleware.py` (+2 -2)
</details>
### 📄 Description
# Description
The `get_active_status_by_user_id()` function returns `True` or `False`, but in https://github.com/open-webui/open-webui/blob/main/backend/open_webui/utils/middleware.py on lines `1136` and `2227`, the result of this function is compared to `None`, which always results in `False`, causing user notification webhooks to never be sent.
**Warning: This PR fixes the ability for users to create webhooks, which can be dangrous under certain conditions! This is known as an SSRF vulnerability. In this particular case the impact is very limited, but it is still classified as a security vulnerability. Please get in touch for more information.**
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests to validate the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
- Fixed a bug that caused user notification webhooks to never be sent
### Added
-
### Changed
-
### Deprecated
-
### Removed
-
### Fixed
- Fixed user notification webhooks not being sent due to incorrect type check
### Security
- **Warning: This PR fixes the ability for users to create webhooks, which can be dangrous under certain conditions! This is known as an SSRF vulnerability. In this particular case the impact is very limited, but it is still classified as a security vulnerability. Please get in touch for more information.**
### Breaking Changes
-
---
### Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the [CONTRIBUTOR_LICENSE_AGREEMENT](CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/13258
Author: @choket
Created: 4/27/2025
Status: ✅ Merged
Merged: 4/28/2025
Merged by: @tjbck
Base:
dev← Head:dev📝 Commits (1)
8a9de0aFix bug that never triggers user notification webhooks📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
backend/open_webui/utils/middleware.py(+2 -2)📄 Description
Description
The
get_active_status_by_user_id()function returnsTrueorFalse, but in https://github.com/open-webui/open-webui/blob/main/backend/open_webui/utils/middleware.py on lines1136and2227, the result of this function is compared toNone, which always results inFalse, causing user notification webhooks to never be sent.Warning: This PR fixes the ability for users to create webhooks, which can be dangrous under certain conditions! This is known as an SSRF vulnerability. In this particular case the impact is very limited, but it is still classified as a security vulnerability. Please get in touch for more information.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
Added
Changed
Deprecated
Removed
Fixed
Security
Breaking Changes
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the CONTRIBUTOR_LICENSE_AGREEMENT, and I am providing my contributions under its terms.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.