[PR #12366] [MERGED] chore: adapt websocket redis sentinel code to new native support in python-socketio #45951

New Issue

GiteaMirror · 2026-04-29T20:33:15-05:00

GiteaMirror commented

2026-04-29 20:33:15 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/12366
Author: @Ithanil
Created: 4/2/2025
Status: ✅ Merged
Merged: 4/12/2025
Merged by: @tjbck

Base: dev ← Head: redis_sentinel_2

📝 Commits (3)

35ea29b prepare websocket redis sentinel code for upcoming native support of sentinel in python-socketio
257ca45 leave out @ in redis+sentine url when no username/password is provided
c6755f9 bump python-socketio to 5.13.0 (to support Redis Sentinel natively)

📊 Changes

5 files changed (+19 additions, -82 deletions)

View changed files

📝 backend/open_webui/socket/main.py (+2 -12)
📝 backend/open_webui/utils/redis.py (+11 -64)
📝 backend/requirements.txt (+1 -1)
📝 pyproject.toml (+1 -1)
📝 uv.lock (+4 -4)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Preparation for upcoming python-socketio release (with PR https://github.com/miguelgrinberg/python-socketio/pull/1448). Will un-draft when ready.
EDIT: python-socketio 5.13.0 with the relevant changes has now been released and is used by this PR

Changed

bump python-socketio to 5.13.0
Use python-socketio's AsyncRedisManager with native Sentinel support

Removed

Custom AsyncRedisSentinelManager

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/12366 **Author:** [@Ithanil](https://github.com/Ithanil) **Created:** 4/2/2025 **Status:** ✅ Merged **Merged:** 4/12/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `redis_sentinel_2` --- ### 📝 Commits (3) - [`35ea29b`](https://github.com/open-webui/open-webui/commit/35ea29b184ca4cf5b96a27429dfc62521873a2d3) prepare websocket redis sentinel code for upcoming native support of sentinel in python-socketio - [`257ca45`](https://github.com/open-webui/open-webui/commit/257ca454569f1c4bd936a039c751f170ab3c6c38) leave out @ in redis+sentine url when no username/password is provided - [`c6755f9`](https://github.com/open-webui/open-webui/commit/c6755f9151fe10295e25bab3212f4756ac675458) bump python-socketio to 5.13.0 (to support Redis Sentinel natively) ### 📊 Changes **5 files changed** (+19 additions, -82 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/socket/main.py` (+2 -12) 📝 `backend/open_webui/utils/redis.py` (+11 -64) 📝 `backend/requirements.txt` (+1 -1) 📝 `pyproject.toml` (+1 -1) 📝 `uv.lock` (+4 -4) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Preparation for upcoming python-socketio release (with PR https://github.com/miguelgrinberg/python-socketio/pull/1448). Will un-draft when ready. EDIT: python-socketio 5.13.0 with the relevant changes has now been released and is used by this PR ### Changed - bump python-socketio to 5.13.0 - Use python-socketio's AsyncRedisManager with native Sentinel support ### Removed - Custom AsyncRedisSentinelManager --- --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 20:33:15 -05:00

GiteaMirror closed this issue

2026-04-29 20:33:17 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#45951