[PR #11936] [MERGED] fix: redirection for users already logged in #45869

New Issue

GiteaMirror · 2026-04-29T20:27:17-05:00

GiteaMirror commented

2026-04-29 20:27:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/11936
Author: @softue
Created: 3/21/2025
Status: ✅ Merged
Merged: 3/21/2025
Merged by: @tjbck

Base: dev ← Head: auth-redirect

📝 Commits (1)

c4c6e02 fix: redirection for users already logged in

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/routes/auth/+page.svelte (+2 -1)

📄 Description

Pull Request Checklist

I think we can continue the original discussion:
Frontend authentication redirection option #10318

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Redirection for users already logged in into Open WebUI. The current version works only when the user is not logged.

Example url (works only when the user is not logged in):
http://localhost:3000/auth?redirect=http://localhost:3000/admin/settings

Changed

This modification is considering redirect query string if the user is not undefined. I am using the same code on setSessionUser introduced by PR #10323.

onMount(async () => {
    if ($user !== undefined) {
        const redirectPath = querystringValue('redirect') || '/';
	goto(redirectPath);
    }
...
});

Fixed

Redirection according redirect query string with authenticated user.

Redirect example using localhost instance:
http://localhost:3000/auth?redirect=http://localhost:3000/admin/settings

Additional Information

This modification complements #10323

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/11936 **Author:** [@softue](https://github.com/softue) **Created:** 3/21/2025 **Status:** ✅ Merged **Merged:** 3/21/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `auth-redirect` --- ### 📝 Commits (1) - [`c4c6e02`](https://github.com/open-webui/open-webui/commit/c4c6e02b4c2b9819b33dc85af1bdeae6ecd80078) fix: redirection for users already logged in ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/routes/auth/+page.svelte` (+2 -1) </details> ### 📄 Description # Pull Request Checklist I think we can continue the original discussion: [Frontend authentication redirection option #10318](https://github.com/open-webui/open-webui/discussions/10318) **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Redirection for users already logged in into Open WebUI. The current version works only when the user is not logged. Example url (works only when the **user is not logged in**): http://localhost:3000/auth?redirect=http://localhost:3000/admin/settings ### Changed This modification is considering redirect query string if the user is not undefined. I am using the same code on `setSessionUser` introduced by PR #10323. ```svelte onMount(async () => { if ($user !== undefined) { const redirectPath = querystringValue('redirect') || '/'; goto(redirectPath); } ... }); ``` ### Fixed Redirection according `redirect` query string with authenticated user. Redirect example using localhost instance: `http://localhost:3000/auth?redirect=http://localhost:3000/admin/settings` --- ### Additional Information This modification complements #10323 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 20:27:17 -05:00

GiteaMirror closed this issue

2026-04-29 20:27:19 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#45869