[PR #10591] [CLOSED] fix: do not allow uninstalling open-webui to install a tool + uv faster than pip #45612

New Issue

GiteaMirror · 2026-04-29T20:02:28-05:00

GiteaMirror commented

2026-04-29 20:02:28 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10591
Author: @thiswillbeyourgithub
Created: 2/22/2025
Status: ❌ Closed

Base: dev ← Head: dev

📝 Commits (1)

4cec1da fix: do not allow uninstalling oprn-webui to install a tool + uv faster than pip

📊 Changes

1 file changed (+7 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/plugin.py (+7 -1)

📄 Description

feat: Implement Document Intelligence as Content Extraction Engine
Update catalan translation.json
Fix on ollama to openai conversion - stream can return a single message with content
Update zh-CN translation
refac
i18n: Update Chinese Translation
feat/async-pipes
fix:Quick selection tool lost
Update audio.py to fetch custom URL voices and models
Update audio.py
Support thinking tags used by Openthinker
Added support for stop parameter
refac
refac
fix: model import
Fix: Ensure user_oauth_groups defaults to an empty list to prevent TypeError
feat: added Trust Proxy Environment switch in Web Search admin settings tab.
refac: code block image styling
Update payload.py
refac
refac
refac
refac
fix: do not allow uninstalling open-webui to install a tool + uv faster than pip

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

In the current state, pip was used to install requirements from tools. This is problematic because pip is slow and because open-webui is completely unresponsive when the command is being run. uv is way faster than pip so this is an improvement but making the dependency installation without hanging is out of scope of this PR.
Doing pip install something can totally break the dependencies needed by openwebui and I ran into several catastrophic failures because of this. I looked up online and both pip and uv seem to support specifying constraints during an install. Hence doing (uv) pip install --overrides /app/backend/requirements.txt [the new dependencies] seems to be safer.

Changed

Faster and safer dependency installation for tools

Fixed

No longer possible t uninstall open-webui or its dependencies by mistake when installing tools.

Security

Made it a bit harder to uninstall open-webui and its dependencies at tool installation.

Additional Information

Note: it is still possible to wreak havoc the env by modifying the /app/backend/requirements.txt file in the tool directly, but at least we can't uninstall open-webui by mistake.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10591 **Author:** [@thiswillbeyourgithub](https://github.com/thiswillbeyourgithub) **Created:** 2/22/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`4cec1da`](https://github.com/open-webui/open-webui/commit/4cec1da55969f9229c802ed069d3c2cc777ed2d8) fix: do not allow uninstalling oprn-webui to install a tool + uv faster than pip ### 📊 Changes **1 file changed** (+7 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/plugin.py` (+7 -1) </details> ### 📄 Description - **feat: Implement Document Intelligence as Content Extraction Engine** - **Update catalan translation.json** - **Fix on ollama to openai conversion - stream can return a single message with content** - **Update zh-CN translation** - **refac** - **i18n: Update Chinese Translation** - **feat/async-pipes** - **fix:Quick selection tool lost** - **Update audio.py to fetch custom URL voices and models** - **Update audio.py** - **Support thinking tags used by Openthinker** - **Added support for stop parameter** - **refac** - **refac** - **fix: model import** - **Fix: Ensure `user_oauth_groups` defaults to an empty list to prevent TypeError** - **feat: added Trust Proxy Environment switch in Web Search admin settings tab.** - **refac: code block image styling** - **Update payload.py** - **refac** - **refac** - **refac** - **refac** - **fix: do not allow uninstalling open-webui to install a tool + uv faster than pip** # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description 1. In the current state, pip was used to install requirements from tools. This is problematic because pip is slow and because open-webui is completely unresponsive when the command is being run. uv is way faster than pip so this is an improvement but making the dependency installation without hanging is out of scope of this PR. 2. Doing `pip install something` can totally break the dependencies needed by openwebui and I ran into several catastrophic failures because of this. I looked up online and both pip and uv seem to support specifying constraints during an install. Hence doing `(uv) pip install --overrides /app/backend/requirements.txt [the new dependencies]` seems to be safer. ### Changed - Faster and safer dependency installation for tools ### Fixed - No longer possible t uninstall open-webui or its dependencies by mistake when installing tools. ### Security - Made it a bit harder to uninstall open-webui and its dependencies at tool installation. --- ### Additional Information Note: it is still possible to wreak havoc the env by modifying the /app/backend/requirements.txt file in the tool directly, but at least we can't uninstall open-webui *by mistake*. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 20:02:28 -05:00

GiteaMirror closed this issue

2026-04-29 20:02:29 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#45612