[PR #10377] [MERGED] **fix** ChatMessage validator: content can be null when using tools #45563

New Issue

GiteaMirror · 2026-04-29T19:59:25-05:00

GiteaMirror commented

2026-04-29 19:59:25 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/10377
Author: @Seniorsimo
Created: 2/19/2025
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @tjbck

Base: dev ← Head: chat-message-validator

📝 Commits (1)

8662108 Fix on ChatMessage validator: content can be null when using tools

📊 Changes

1 file changed (+11 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/ollama.py (+11 -2)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed the ChatMessage validation: content can be null when using tools, for example, this should be a valid accepted message call (the third message has no content)

"messages": [
	{
		"content": "You are a helpful assistant", 
		"role": "system"
	}, {
		"content": "It feels so cold today in NY.", 
		"role": "user"
	}, {
		"role": "assistant", 
		"tool_calls": [
			{
				"type": "function", 
				"id": "call_1f82a3f7-7fe3-45a9-9de7-e03949b83563", 
				"function": {
					"name": "weather", 
					"arguments": "{\"city\": \"New York\"}"
				}
			}
		]
	}, {
		"content": "The weather in New York is 37 degrees.", 
		"role": "tool", 
		"tool_call_id": "call_1f82a3f7-7fe3-45a9-9de7-e03949b83563"
	}
]

Fixed

ChatMessage validator should handle message with null content when tool calls are present

Additional Information

All the changes are tested and validated using this notebook file.
https://gist.github.com/Seniorsimo/214e39d7da6a72bff98f265a39c2fa14

Tested the varius intagration using:

OpenAI vs Open WebUI (gpt-3.5-turbo)
Ollama vs Open WebUI (qwen2.5:14b)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/10377 **Author:** [@Seniorsimo](https://github.com/Seniorsimo) **Created:** 2/19/2025 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `chat-message-validator` --- ### 📝 Commits (1) - [`8662108`](https://github.com/open-webui/open-webui/commit/8662108344424960b1dab6eca0799217efd851f5) Fix on ChatMessage validator: content can be null when using tools ### 📊 Changes **1 file changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/ollama.py` (+11 -2) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests for validating the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed the ChatMessage validation: content can be null when using tools, for example, this should be a valid accepted message call (the third message has no content) ```json "messages": [ { "content": "You are a helpful assistant", "role": "system" }, { "content": "It feels so cold today in NY.", "role": "user" }, { "role": "assistant", "tool_calls": [ { "type": "function", "id": "call_1f82a3f7-7fe3-45a9-9de7-e03949b83563", "function": { "name": "weather", "arguments": "{\"city\": \"New York\"}" } } ] }, { "content": "The weather in New York is 37 degrees.", "role": "tool", "tool_call_id": "call_1f82a3f7-7fe3-45a9-9de7-e03949b83563" } ] ``` ### Fixed - ChatMessage validator should handle message with null content when tool calls are present --- ### Additional Information All the changes are tested and validated using this notebook file. https://gist.github.com/Seniorsimo/214e39d7da6a72bff98f265a39c2fa14 Tested the varius intagration using: OpenAI vs Open WebUI (gpt-3.5-turbo) Ollama vs Open WebUI (qwen2.5:14b) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 19:59:25 -05:00

GiteaMirror closed this issue

2026-04-29 19:59:26 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#45563