Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
BREAKING CHANGE: Significant changes that may affect compatibility
build: Changes that affect the build system or external dependencies
ci: Changes to our continuous integration processes or workflows
chore: Refactor, cleanup, or other non-functional code changes
docs: Documentation update or addition
feat: Introduces a new feature or enhancement to the codebase
fix: Bug fix or error correction
i18n: Internationalization or localization changes
perf: Performance improvement
refactor: Code restructuring for better maintainability, readability, or scalability
style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
test: Adding missing tests or correcting existing tests
WIP: Work in progress, a temporary label for incomplete or ongoing work
Changelog Entry
Description
This PR fixes batched embedding for OpenAI endpoints. As a side change, it also removes various print statements from the rag app, which is likely a byproduct of debugging. Closes#5698, and fixes#5637.
Removed
Removed unnecessary print statements from RAG app.
Fixed
Fixed batching for OpenAI embedding endpoints.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/open-webui/open-webui/pull/5728
**Author:** [@sp301415](https://github.com/sp301415)
**Created:** 9/26/2024
**Status:** ✅ Merged
**Merged:** 9/26/2024
**Merged by:** [@tjbck](https://github.com/tjbck)
**Base:** `dev` ← **Head:** `dev`
---
### 📝 Commits (2)
- [`a4bc0b2`](https://github.com/open-webui/open-webui/commit/a4bc0b2829a6260d33e84a5768409e338d5fbb34) fix: Fix OpenAI batch embedding
- [`4fe1f24`](https://github.com/open-webui/open-webui/commit/4fe1f2487dde8458964d756a402c0a9278f87620) fix: Fix OpenAI batch embedding
### 📊 Changes
**3 files changed** (+5 additions, -7 deletions)
<details>
<summary>View changed files</summary>
📝 `backend/open_webui/apps/rag/main.py` (+5 -1)
📝 `backend/open_webui/apps/rag/utils.py` (+0 -2)
📝 `backend/open_webui/apps/rag/vector/dbs/milvus.py` (+0 -4)
</details>
### 📄 Description
# Pull Request Checklist
### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request.
**Before submitting, make sure you've checked the following:**
- [x] **Target branch:** Please verify that the pull request targets the `dev` branch.
- [x] **Description:** Provide a concise description of the changes made in this pull request.
- [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description.
- [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources?
- [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation?
- [x] **Testing:** Have you written and run sufficient tests for validating the changes?
- [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
- [x] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following:
- **BREAKING CHANGE**: Significant changes that may affect compatibility
- **build**: Changes that affect the build system or external dependencies
- **ci**: Changes to our continuous integration processes or workflows
- **chore**: Refactor, cleanup, or other non-functional code changes
- **docs**: Documentation update or addition
- **feat**: Introduces a new feature or enhancement to the codebase
- **fix**: Bug fix or error correction
- **i18n**: Internationalization or localization changes
- **perf**: Performance improvement
- **refactor**: Code restructuring for better maintainability, readability, or scalability
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- **test**: Adding missing tests or correcting existing tests
- **WIP**: Work in progress, a temporary label for incomplete or ongoing work
# Changelog Entry
### Description
This PR fixes batched embedding for OpenAI endpoints. As a side change, it also removes various `print` statements from the rag app, which is likely a byproduct of debugging.
Closes #5698, and fixes #5637.
### Removed
- Removed unnecessary `print` statements from RAG app.
### Fixed
- Fixed batching for OpenAI embedding endpoints.
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/open-webui/open-webui/pull/5728
Author: @sp301415
Created: 9/26/2024
Status: ✅ Merged
Merged: 9/26/2024
Merged by: @tjbck
Base:
dev← Head:dev📝 Commits (2)
a4bc0b2fix: Fix OpenAI batch embedding4fe1f24fix: Fix OpenAI batch embedding📊 Changes
3 files changed (+5 additions, -7 deletions)
View changed files
📝
backend/open_webui/apps/rag/main.py(+5 -1)📝
backend/open_webui/apps/rag/utils.py(+0 -2)📝
backend/open_webui/apps/rag/vector/dbs/milvus.py(+0 -4)📄 Description
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.
Before submitting, make sure you've checked the following:
devbranch.Changelog Entry
Description
This PR fixes batched embedding for OpenAI endpoints. As a side change, it also removes various
printstatements from the rag app, which is likely a byproduct of debugging.Closes #5698, and fixes #5637.
Removed
printstatements from RAG app.Fixed
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.