[PR #4024] [MERGED] fix: seed and temperature can be 0 in models #44430

New Issue

GiteaMirror · 2026-04-29T18:32:25-05:00

GiteaMirror commented

2026-04-29 18:32:25 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/4024
Author: @Seth-Rothschild
Created: 7/20/2024
Status: ✅ Merged
Merged: 7/20/2024
Merged by: @tjbck

Base: dev ← Head: fix-seed-0

📝 Commits (1)

c3693c9 fix: allow temperature and seed to be 0

📊 Changes

2 files changed (+7 additions, -4 deletions)

View changed files

📝 backend/apps/ollama/main.py (+2 -2)
📝 backend/apps/openai/main.py (+5 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests for validating the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To cleary categorize this pull request, prefix the pull request title, using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

fixes a bug where setting seed=0 or temperature=0 in models is ignored

Fixed

fixed a bug where setting seed=0 or temperature=0 in a model was ignored

Additional Information

the param was only added to options when if model_info.params.get("temperature", None), which is False when temperature is 0. Changed it to if model_info.params.get("temperature", None) is not None.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/4024 **Author:** [@Seth-Rothschild](https://github.com/Seth-Rothschild) **Created:** 7/20/2024 **Status:** ✅ Merged **Merged:** 7/20/2024 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-seed-0` --- ### 📝 Commits (1) - [`c3693c9`](https://github.com/open-webui/open-webui/commit/c3693c91b37718a31ef966b8bed14c98674028b8) fix: allow temperature and seed to be 0 ### 📊 Changes **2 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/apps/ollama/main.py` (+2 -2) 📝 `backend/apps/openai/main.py` (+5 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [ ] **Testing:** Have you written and run sufficient tests for validating the changes? - [ ] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To cleary categorize this pull request, prefix the pull request title, using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - fixes a bug where setting seed=0 or temperature=0 in models is ignored ### Fixed - fixed a bug where setting seed=0 or temperature=0 in a model was ignored --- ### Additional Information - the param was only added to options when `if model_info.params.get("temperature", None)`, which is `False` when `temperature` is 0. Changed it to `if model_info.params.get("temperature", None) is not None`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-29 18:32:25 -05:00

GiteaMirror closed this issue

2026-04-29 18:32:26 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#44430