github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-08 21:09:41 -05:00
Code Issues 1.3k Packages Projects Releases 126 Wiki Activity

[PR #23690] [CLOSED] feat: replace Google favicon API with backend proxy #42947

New Issue
Closed
opened 2026-04-25 14:42:17 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 14:42:17 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23690
Author: @Algorithm5838
Created: 4/14/2026
Status: ❌ Closed

Base: dev ← Head: feat/favicon-proxy

📝 Commits (1)

  • 6554c47 feat: replace Google favicon API with backend proxy

📊 Changes

3 files changed (+186 additions, -4 deletions)

View changed files

📝 backend/open_webui/routers/utils.py (+177 -1)
📝 src/lib/components/chat/Messages/Citations.svelte (+1 -1)
📝 src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte (+8 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Source icons in RAG citations and web search results were fetched client-side via Google's undocumented favicon service, leaking every cited domain to Google's servers and breaking entirely in offline or air-gapped environments.

This PR adds a backend proxy endpoint (GET /api/v1/utils/favicon?url=...) that fetches favicons server-side:

  1. Try https://{domain}/favicon.ico directly.
  2. If that fails, fetch the homepage and parse <link rel="icon"> tags, picking the best format (SVG > PNG > ICO, larger size preferred).
  3. Fall back to Open WebUI's own /favicon.png.

Results are cached in memory by domain. Citations.svelte and WebSearchResults.svelte are updated to use the new endpoint.

Added

  • GET /api/v1/utils/favicon?url=<encoded-url> in backend/open_webui/routers/utils.py

Changed

  • Citations.svelte and WebSearchResults.svelte: source icon URLs updated from the Google S2 favicon service to the new endpoint.

Deprecated

  • [List any deprecated functionality or features that have been removed]

Removed

  • [List any removed features, files, or functionalities]

Fixed

  • Missing on:error fallback in WebSearchResults.svelte.

Security

  • Cited source domains are no longer sent to Google.
  • The endpoint requires a verified user session.
  • _is_safe_host() validates the resolved IP of both the domain and any parsed icon URL using socket.getaddrinfo + ipaddress, blocking loopback, private, link-local, and multicast addresses.

Breaking Changes

  • BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

  • Relative href values are resolved via urljoin, data: URIs are skipped, a browser User-Agent header is set, and a 5-second timeout is applied per request.
  • Content-type is detected from magic bytes in the response.
  • Responses are capped at 200 KB; oversized payloads are skipped in both fetch phases.
  • In-memory cache is bounded at 1024 entries; failures are not cached, so they retry automatically.
  • Both fetch phases log at DEBUG level on failure.
  • _is_safe_host() DNS resolution runs via asyncio.to_thread so the event loop is not blocked.
  • Icons served with type="image/svg+xml" may not have a file extension, so the scorer checks the file extension first and falls back to the MIME subtype.

Screenshots or Videos

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23690 **Author:** [@Algorithm5838](https://github.com/Algorithm5838) **Created:** 4/14/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feat/favicon-proxy` --- ### 📝 Commits (1) - [`6554c47`](https://github.com/open-webui/open-webui/commit/6554c47bb48a1f8ecd57e5210de86bf8c1abb68d) feat: replace Google favicon API with backend proxy ### 📊 Changes **3 files changed** (+186 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/utils.py` (+177 -1) 📝 `src/lib/components/chat/Messages/Citations.svelte` (+1 -1) 📝 `src/lib/components/chat/Messages/ResponseMessage/WebSearchResults.svelte` (+8 -2) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Source icons in RAG citations and web search results were fetched client-side via Google's undocumented favicon service, leaking every cited domain to Google's servers and breaking entirely in offline or air-gapped environments. This PR adds a backend proxy endpoint (`GET /api/v1/utils/favicon?url=...`) that fetches favicons server-side: 1. Try `https://{domain}/favicon.ico` directly. 2. If that fails, fetch the homepage and parse `<link rel="icon">` tags, picking the best format (SVG > PNG > ICO, larger size preferred). 3. Fall back to Open WebUI's own `/favicon.png`. Results are cached in memory by domain. `Citations.svelte` and `WebSearchResults.svelte` are updated to use the new endpoint. ### Added - `GET /api/v1/utils/favicon?url=<encoded-url>` in `backend/open_webui/routers/utils.py` ### Changed - `Citations.svelte` and `WebSearchResults.svelte`: source icon URLs updated from the Google S2 favicon service to the new endpoint. ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - [List any removed features, files, or functionalities] ### Fixed - Missing `on:error` fallback in `WebSearchResults.svelte`. ### Security - Cited source domains are no longer sent to Google. - The endpoint requires a verified user session. - `_is_safe_host()` validates the resolved IP of both the domain and any parsed icon URL using `socket.getaddrinfo` + `ipaddress`, blocking loopback, private, link-local, and multicast addresses. ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - Relative `href` values are resolved via `urljoin`, `data:` URIs are skipped, a browser `User-Agent` header is set, and a 5-second timeout is applied per request. - Content-type is detected from magic bytes in the response. - Responses are capped at 200 KB; oversized payloads are skipped in both fetch phases. - In-memory cache is bounded at 1024 entries; failures are not cached, so they retry automatically. - Both fetch phases log at `DEBUG` level on failure. - `_is_safe_host()` DNS resolution runs via `asyncio.to_thread` so the event loop is not blocked. - Icons served with `type="image/svg+xml"` may not have a file extension, so the scorer checks the file extension first and falls back to the MIME subtype. ### Screenshots or Videos - [Attach any relevant screenshots or videos demonstrating the changes] ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 14:42:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#42947
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?