[PR #23638] [MERGED] fix: enforce filter_allowed_access_grants on channel create and update #42925

New Issue

GiteaMirror · 2026-04-25T14:41:21-05:00

GiteaMirror commented

2026-04-25 14:41:21 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23638
Author: @Classic298
Created: 4/12/2026
Status: ✅ Merged
Merged: 4/12/2026
Merged by: @tjbck

Base: dev ← Head: fix/channel-access-grants-bypass

📝 Commits (1)

6e7a7b7 fix: enforce filter_allowed_access_grants on channel create and update

📊 Changes

1 file changed (+17 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/channels.py (+17 -1)

📄 Description

Unlike all other resource routers (knowledge, models, notes, prompts, tools, skills), the channel router did not call filter_allowed_access_grants. This allowed any user to set wildcard access grants on group channels, bypassing the admin's public sharing permission framework.

Adds filter_allowed_access_grants with the sharing.public_channels permission key to both create and update endpoints, matching the pattern used by all other resource routers.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23638 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 4/12/2026 **Status:** ✅ Merged **Merged:** 4/12/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/channel-access-grants-bypass` --- ### 📝 Commits (1) - [`6e7a7b7`](https://github.com/open-webui/open-webui/commit/6e7a7b734616848239fee0ad9f13419e0222eedf) fix: enforce filter_allowed_access_grants on channel create and update ### 📊 Changes **1 file changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/channels.py` (+17 -1) </details> ### 📄 Description Unlike all other resource routers (knowledge, models, notes, prompts, tools, skills), the channel router did not call filter_allowed_access_grants. This allowed any user to set wildcard access grants on group channels, bypassing the admin's public sharing permission framework. Adds filter_allowed_access_grants with the sharing.public_channels permission key to both create and update endpoints, matching the pattern used by all other resource routers. ### Contributor License Agreement  - [X] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 14:41:21 -05:00

GiteaMirror closed this issue

2026-04-25 14:41:23 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#42925