github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #23042] [CLOSED] fix: remove null bytes from metadata to prevent PostgreSQL JSONB errors #42621

New Issue
Closed
opened 2026-04-25 14:27:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 14:27:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/23042
Author: @yang1002378395-cmyk
Created: 3/25/2026
Status: ❌ Closed

Base: dev ← Head: fix-pdf-null-byte-v2

📝 Commits (1)

  • 7972e61 fix: remove null bytes from metadata to prevent PostgreSQL JSONB errors

📊 Changes

1 file changed (+25 additions, -5 deletions)

View changed files

📝 backend/open_webui/retrieval/vector/utils.py (+25 -5)

📄 Description

Summary

Two UX improvements for tool call feedback:

  1. File metadata fix: Remove duplicate display of file path when file_meta has no content, avoiding redundant information.
  2. Loading indicator: Show "Generating response..." with shimmer effect when all tool calls complete but LLM response hasn't started streaming yet.

Changes

  • StatusItem.svelte: Fixed file metadata display logic
  • StatusHistory.svelte: Added loading indicator for post-tool-call waiting period
  • ResponseMessage.svelte: Pass messageDone prop to StatusHistory

Test Plan

  1. Use a tool/function call in chat
  2. Observe status history shows tool execution
  3. After tool completes, "Generating response..." appears with shimmer
  4. LLM response streams in, indicator disappears

Fixes #22970

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/23042 **Author:** [@yang1002378395-cmyk](https://github.com/yang1002378395-cmyk) **Created:** 3/25/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-pdf-null-byte-v2` --- ### 📝 Commits (1) - [`7972e61`](https://github.com/open-webui/open-webui/commit/7972e614a28c3d9089bcef26d787e39c6605d309) fix: remove null bytes from metadata to prevent PostgreSQL JSONB errors ### 📊 Changes **1 file changed** (+25 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/vector/utils.py` (+25 -5) </details> ### 📄 Description ## Summary Two UX improvements for tool call feedback: 1. **File metadata fix**: Remove duplicate display of file path when `file_meta` has no content, avoiding redundant information. 2. **Loading indicator**: Show "Generating response..." with shimmer effect when all tool calls complete but LLM response hasn't started streaming yet. ## Changes - `StatusItem.svelte`: Fixed file metadata display logic - `StatusHistory.svelte`: Added loading indicator for post-tool-call waiting period - `ResponseMessage.svelte`: Pass `messageDone` prop to StatusHistory ## Test Plan 1. Use a tool/function call in chat 2. Observe status history shows tool execution 3. After tool completes, "Generating response..." appears with shimmer 4. LLM response streams in, indicator disappears Fixes #22970 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 14:27:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#42621
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?