github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-05-06 10:58:17 -05:00
Code Issues 1.2k Packages Projects Releases 126 Wiki Activity

[PR #22679] [CLOSED] fix: optimize file handling for full context mode to reduce chat latency #42441

New Issue
Closed
opened 2026-04-25 14:20:42 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 14:20:42 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22679
Author: @a86582751
Created: 3/14/2026
Status: ❌ Closed

Base: dev ← Head: fix-full-context-bypass-rag

📝 Commits (10+)

📊 Changes

1 file changed (+100 additions, -33 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+100 -33)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
  • Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes.
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic.
  • Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included.

Changelog Entry

Description

  • Fixed significant delay (up to 40 seconds) when sending messages in "Full Context" mode by directly loading file contents from the database and injecting them into the user message, fully bypassing the RAG pipeline and frontend serialization of large files.

Fixed

  • Fixed the issue where get_sources_from_items was still being called even when all_full_context or bypass_embedding was true.
  • Fixed severe frontend serialization latency caused by passing full file contents (especially large 200KB+ documents) in the JSON request body.
  • Fixed confusing UI state where "sources_retrieved" was emitted even when retrieval was skipped.

Additional Information

  • This fix drastically improves performance for Role-Play scenarios and large document contexts.
  • Performance test (264KB DOCX): Before this fix, frontend serialization took ~36s and RAG took ~2-5s (Total latency ~40s). After this fix, backend loading takes <100ms and injection takes <10ms (Total latency <200ms). This is an improvement of nearly 200x.
  • Supports all file types handled by Open WebUI Loaders (DOCX, PDF, TXT/MD, Images). Normal RAG retrieval and mixed-mode (partial full + partial retrieval) remain fully functional.
  • Changes made in backend/open_webui/utils/middleware.py: Added checks for all_full_context and bypass_embedding to directly load content and append it as [Attached Files Context] before returning, skipping generation and embedding stages entirely.

Screenshots or Videos

  • before:
    Use Focused Retrieval
    默认设置1
    默认设置2

use Full Contextm，But the response is slow.:
image

  • after:
    The response speed for chatting with large files has significantly improved.
    image
    image
    The RAG functionality remains unaffected.：
    image

Contributor License Agreement

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22679 **Author:** [@a86582751](https://github.com/a86582751) **Created:** 3/14/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-full-context-bypass-rag` --- ### 📝 Commits (10+) - [`fe6783c`](https://github.com/open-webui/open-webui/commit/fe6783c16699911c7be17392596d579333fb110c) Merge pull request #19030 from open-webui/dev - [`fc05e0a`](https://github.com/open-webui/open-webui/commit/fc05e0a6c5d39da60b603b4d520f800d6e36f748) Merge pull request #19405 from open-webui/dev - [`e3faec6`](https://github.com/open-webui/open-webui/commit/e3faec62c58e3a83d89aa3df539feacefa125e0c) Merge pull request #19416 from open-webui/dev - [`9899293`](https://github.com/open-webui/open-webui/commit/9899293f050ad50ae12024cbebee7e018acd851e) Merge pull request #19448 from open-webui/dev - [`140605e`](https://github.com/open-webui/open-webui/commit/140605e660b8186a7d5c79fb3be6ffb147a2f498) Merge pull request #19462 from open-webui/dev - [`6f1486f`](https://github.com/open-webui/open-webui/commit/6f1486ffd0cb288d0e21f41845361924e0d742b3) Merge pull request #19466 from open-webui/dev - [`d95f533`](https://github.com/open-webui/open-webui/commit/d95f533214e3fe5beb5e41ec1f349940bc4c7043) Merge pull request #19729 from open-webui/dev - [`a727153`](https://github.com/open-webui/open-webui/commit/a7271532f8a38da46785afcaa7e65f9a45e7d753) 0.6.43 (#20093) - [`6adde20`](https://github.com/open-webui/open-webui/commit/6adde203cd292a9e3af9c64a2ae36b603fed096a) Merge pull request #20394 from open-webui/dev - [`f9b0534`](https://github.com/open-webui/open-webui/commit/f9b0534e0c442631d1cb7205169588b9b6204179) Merge pull request #20522 from open-webui/dev ### 📊 Changes **1 file changed** (+100 additions, -33 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+100 -33) </details> ### 📄 Description <!-- ⚠️ CRITICAL CHECKS FOR CONTRIBUTORS (READ, DON'T DELETE) ⚠️ 1. Target the `dev` branch. PRs targeting `main` will be automatically closed. 2. Do NOT delete the CLA section at the bottom. It is required for the bot to accept your PR. --> # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description. - [ ] **Documentation:** Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [ ] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. # Changelog Entry ### Description - Fixed significant delay (up to 40 seconds) when sending messages in "Full Context" mode by directly loading file contents from the database and injecting them into the user message, fully bypassing the RAG pipeline and frontend serialization of large files. ### Fixed - Fixed the issue where `get_sources_from_items` was still being called even when `all_full_context` or `bypass_embedding` was true. - Fixed severe frontend serialization latency caused by passing full file contents (especially large 200KB+ documents) in the JSON request body. - Fixed confusing UI state where "sources_retrieved" was emitted even when retrieval was skipped. --- ### Additional Information - This fix drastically improves performance for Role-Play scenarios and large document contexts. - **Performance test (264KB DOCX):** Before this fix, frontend serialization took ~36s and RAG took ~2-5s (Total latency ~40s). After this fix, backend loading takes <100ms and injection takes <10ms (Total latency <200ms). This is an improvement of nearly 200x. - Supports all file types handled by Open WebUI Loaders (DOCX, PDF, TXT/MD, Images). Normal RAG retrieval and mixed-mode (partial full + partial retrieval) remain fully functional. - Changes made in `backend/open_webui/utils/middleware.py`: Added checks for `all_full_context` and `bypass_embedding` to directly load content and append it as `[Attached Files Context]` before returning, skipping generation and embedding stages entirely. ### Screenshots or Videos - before: Use Focused Retrieval <img width="2630" height="1585" alt="默认设置1" src="https://github.com/user-attachments/assets/bc8d7b98-c975-446c-ae83-9923268a4339" /> <img width="2481" height="1324" alt="默认设置2" src="https://github.com/user-attachments/assets/2b200d93-2b5a-44aa-8826-f8a4e6389584" /> use Full Contextm，But the response is slow.: <img width="2569" height="1287" alt="image" src="https://github.com/user-attachments/assets/90f4a2b0-9081-42fe-9659-9403812f9a0e" /> - after: The response speed for chatting with large files has significantly improved. <img width="2762" height="1533" alt="image" src="https://github.com/user-attachments/assets/cd56c61e-ab3f-4e24-aecd-e9d73343718d" /> <img width="2640" height="1261" alt="image" src="https://github.com/user-attachments/assets/ee4aaebb-c999-402c-82dc-6349f93cff08" /> The RAG functionality remains unaffected.： <img width="2994" height="1703" alt="image" src="https://github.com/user-attachments/assets/a148e6b7-ef30-43e2-aeb4-018b4b612631" /> ### Contributor License Agreement <!-- 🚨 DO NOT DELETE THE TEXT BELOW 🚨 Keep the "Contributor License Agreement" confirmation text intact. Deleting it will trigger the CLA-Bot to INVALIDATE your PR. Your PR will NOT be reviewed or merged until you check the box below confirming that you have read and agree to the terms of the CLA. --> - [x] By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 14:20:42 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#42441
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?