[PR #22273] [MERGED] fix: use NullPool for SQLCipher engine to prevent segfault #42209

New Issue

GiteaMirror · 2026-04-25T14:12:02-05:00

GiteaMirror commented

2026-04-25 14:12:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/22273
Author: @Classic298
Created: 3/5/2026
Status: ✅ Merged
Merged: 3/6/2026
Merged by: @tjbck

Base: dev ← Head: fix/sqlcipher-pool-type

📝 Commits (1)

f04d8b1 fix: use NullPool for SQLCipher engine to prevent segfault

📊 Changes

1 file changed (+24 additions, -5 deletions)

View changed files

📝 backend/open_webui/internal/db.py (+24 -5)

📄 Description

The SQLCipher engine used a dummy sqlite:// URL with a creator function, which caused SQLAlchemy to auto-select SingletonThreadPool. This pool non-deterministically closes in-use connections when thread count exceeds pool_size (default 5), leading to use-after-free segfaults (exit code 139) in the native sqlcipher3 C library during multi-threaded operations like user signup.

Now defaults to NullPool (each operation creates/closes its own connection) for maximum safety with the native C extension. Also respects the DATABASE_POOL_SIZE setting: if explicitly set >0, QueuePool is used with the configured pool parameters, matching the behavior of other DB paths.

Fixes #22258

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/22273 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 3/5/2026 **Status:** ✅ Merged **Merged:** 3/6/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/sqlcipher-pool-type` --- ### 📝 Commits (1) - [`f04d8b1`](https://github.com/open-webui/open-webui/commit/f04d8b13b29fb10418dbc21cdf5de40a1da85a85) fix: use NullPool for SQLCipher engine to prevent segfault ### 📊 Changes **1 file changed** (+24 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/internal/db.py` (+24 -5) </details> ### 📄 Description The SQLCipher engine used a dummy sqlite:// URL with a creator function, which caused SQLAlchemy to auto-select SingletonThreadPool. This pool non-deterministically closes in-use connections when thread count exceeds pool_size (default 5), leading to use-after-free segfaults (exit code 139) in the native sqlcipher3 C library during multi-threaded operations like user signup. Now defaults to NullPool (each operation creates/closes its own connection) for maximum safety with the native C extension. Also respects the DATABASE_POOL_SIZE setting: if explicitly set >0, QueuePool is used with the configured pool parameters, matching the behavior of other DB paths. Fixes #22258 ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 14:12:02 -05:00

GiteaMirror closed this issue

2026-04-25 14:12:05 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#42209