[PR #21713] [MERGED] fix: explicitly disable dragging and text selection inside dropdown menus #41861

New Issue

GiteaMirror · 2026-04-25T13:57:50-05:00

GiteaMirror commented

2026-04-25 13:57:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21713
Author: @silentoplayz
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @tjbck

Base: dev ← Head: fix/chat-menu-drag-glitch

📝 Commits (2)

020d58b fix(ui): remove select-none from move and pdf menu items to allow highlighting
577ca26 fix(ui): explicitly disable dragging and text selection inside dropdown menus globally

📊 Changes

2 files changed (+31 additions, -31 deletions)

View changed files

📝 src/lib/components/layout/Navbar/Menu.svelte (+16 -16)
📝 src/lib/components/layout/Sidebar/ChatMenu.svelte (+15 -15)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. PRs targeting main will be immediately closed.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Add docs in Open WebUI Docs Repository. Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps.
Dependencies: Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash.
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to make screenshots of the feature/fix and include them in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Design & Architecture: Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes.
Git Hygiene: Keep PRs atomic (one logical change). Clean up commits and rebase on dev to ensure no unrelated commits (e.g. from main) are included. Push updates to the existing PR branch instead of closing and reopening.
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

Fixed a bug where dropdown menu items (such as the actions list inside ChatMenu.svelte or Navbar/Menu.svelte) could be highlighted with native text selection tools inside the browser and mistakenly dragged out of context as ghost anomalies.

Added

Secured every DropdownMenu.Item and DropdownMenu.SubTrigger mapping component inside ChatMenu.svelte and Navbar/Menu.svelte with strictly encapsulated draggable="false" rules.
Included the Tailwind utility select-none explicitly to all instances of <DropdownMenu.Content> and <DropdownMenu.SubContent> block mappings internally bridging those identical route modules.

Fixed

Eliminated native HTML5 text highlight sweeping alongside ghost-dragging regressions cleanly globally across standard sub-list chat functionality menus.

Screenshots

Before

After

Additional Information

Context: Although restoring parity by systematically scrubbing select-none directly enabled visual parity across Move and PDF document options to match other links initially when highlighting sweeping gestures were utilized, it simultaneously exposed an identical drag-glitch loophole inherently allowing any user highlighting text in those specific menus native freedom to drag the selected options as massive transparent ghost images matching the same constraints observed in the Administration navigation tabs earlier.
By globally targeting the DropdownMenu.Content wrapper layout components bounding those selections locally using class="select-none" coupled tightly alongside draggable="false" constraints dynamically mirroring the exact patches pushed upstream for top-level headers inherently shields all dropdown list-element components flawlessly indefinitely.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21713 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/chat-menu-drag-glitch` --- ### 📝 Commits (2) - [`020d58b`](https://github.com/open-webui/open-webui/commit/020d58bfa8fd7cf6355400a5a80e9b4828ac19bf) fix(ui): remove select-none from move and pdf menu items to allow highlighting - [`577ca26`](https://github.com/open-webui/open-webui/commit/577ca26c9f01e992bfc73ad1f17a5587fb523396) fix(ui): explicitly disable dragging and text selection inside dropdown menus globally ### 📊 Changes **2 files changed** (+31 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/layout/Navbar/Menu.svelte` (+16 -16) 📝 `src/lib/components/layout/Sidebar/ChatMenu.svelte` (+15 -15) </details> ### 📄 Description  # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **PRs targeting `main` will be immediately closed.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Add docs in [Open WebUI Docs Repository](https://github.com/open-webui/docs). Document user-facing behavior, environment variables, public APIs/interfaces, or deployment steps. - [x] **Dependencies:** Are there any new or upgraded dependencies? If so, explain why, update the changelog/docs, and include any compatibility notes. Actually run the code/function that uses updated library to ensure it doesn't crash. - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Include reproducible steps to demonstrate the issue before the fix. Test edge cases (URL encoding, HTML entities, types). Take this as an opportunity to **make screenshots of the feature/fix and include them in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Design & Architecture:** Prefer smart defaults over adding new settings; use local state for ephemeral UI logic. Open a Discussion for major architectural or UX changes. - [x] **Git Hygiene:** Keep PRs atomic (one logical change). Clean up commits and rebase on `dev` to ensure no unrelated commits (e.g. from `main`) are included. Push updates to the existing PR branch instead of closing and reopening. - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed a bug where dropdown menu items (such as the actions list inside `ChatMenu.svelte` or `Navbar/Menu.svelte`) could be highlighted with native text selection tools inside the browser and mistakenly dragged out of context as ghost anomalies. ### Added - Secured every `DropdownMenu.Item` and `DropdownMenu.SubTrigger` mapping component inside `ChatMenu.svelte` and `Navbar/Menu.svelte` with strictly encapsulated `draggable="false"` rules. - Included the Tailwind utility `select-none` explicitly to all instances of `<DropdownMenu.Content>` and `<DropdownMenu.SubContent>` block mappings internally bridging those identical route modules. ### Fixed - Eliminated native HTML5 text highlight sweeping alongside ghost-dragging regressions cleanly globally across standard sub-list chat functionality menus. --- ### Screenshots ### Before <img width="239" height="333" alt="image" src="https://github.com/user-attachments/assets/44103150-a98b-4a64-9210-73777c113aca" /> <img width="448" height="327" alt="image" src="https://github.com/user-attachments/assets/98f583c5-dee3-4a47-83d5-b966eda64bbb" /> <img width="451" height="422" alt="image" src="https://github.com/user-attachments/assets/b8fa3123-bb09-4a61-a92d-9e7c197e8109" /> <img width="299" height="319" alt="image" src="https://github.com/user-attachments/assets/eeaeabaa-e86c-4698-baa2-4dbe8c90370f" /> ### After <img width="239" height="333" alt="image" src="https://github.com/user-attachments/assets/839cf8e2-f6ac-4e9b-9667-15574b757b7f" /> <img width="448" height="327" alt="image" src="https://github.com/user-attachments/assets/e826cd6e-098f-470a-8888-c2fb6b912ec9" /> <img width="451" height="422" alt="image" src="https://github.com/user-attachments/assets/f44ce69c-3b34-43dd-ba90-39dff4e74da4" /> <img width="299" height="319" alt="image" src="https://github.com/user-attachments/assets/844a9b9b-b2fb-4724-8dbb-74e5f4f1d438" /> ### Additional Information - **Context**: Although restoring parity by systematically scrubbing `select-none` directly enabled visual parity across `Move` and `PDF document` options to match other links initially when highlighting sweeping gestures were utilized, it simultaneously exposed an identical drag-glitch loophole inherently allowing any user highlighting text in those specific menus native freedom to drag the selected options as massive transparent ghost images matching the same constraints observed in the Administration navigation tabs earlier. By globally targeting the `DropdownMenu.Content` wrapper layout components bounding those selections locally using `class="select-none"` coupled tightly alongside `draggable="false"` constraints dynamically mirroring the exact patches pushed upstream for top-level headers inherently shields all dropdown list-element components flawlessly indefinitely. ### Contributor License Agreement  By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:57:50 -05:00

GiteaMirror closed this issue

2026-04-25 13:57:56 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41861