[PR #21118] [CLOSED] fix: skip RAG context injection for native function calling #41566

New Issue

GiteaMirror · 2026-04-25T13:45:46-05:00

GiteaMirror commented

2026-04-25 13:45:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/21118
Author: @rbb-dev
Created: 2/3/2026
Status: ❌ Closed

Base: dev ← Head: fix/native-fc-rag-duplication

📝 Commits (1)

4b28403 fix: skip RAG context injection for native function calling

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 backend/open_webui/utils/middleware.py (+1 -1)

📄 Description

When native function calling is enabled, tool results are already sent to the model as function_call_output messages. However, apply_source_context_to_messages() was also injecting these same results as RAG context into user messages, causing token duplication.

The fix adds a check to skip RAG context injection when function_calling is set to "native", consistent with similar checks already present for web_search, memory, and image_generation handlers.

Pull Request Checklist

Target branch: Verify that the pull request targets the dev branch.
Description: Provided above.
Changelog: See below.
Documentation: N/A - no docs changes needed.
Dependencies: No new dependencies.
Testing: Tested manually with native function calling enabled.
Agentic AI Code: Human reviewed and tested.
Code review: Self-reviewed.
Title Prefix: fix:

Changelog Entry

Description

Skip redundant RAG context injection when using native function calling - tool results were being sent twice (as function_call_output AND as RAG context in user messages).

Added

N/A

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

Tool results no longer duplicated in requests when native function calling is enabled

Security

N/A

Breaking Changes

N/A

Additional Information

Follows the same pattern already used for web_search, memory, and image_generation handlers at lines 1573, 1580, and 1587.
Related: #19098, [PR #837] [MERGED] feat: enable title generation prompt edit (#20479)

Question for Maintainers

Is the RAG context injection after tool execution intentional for native function calling?
If citation formatting is needed, perhaps a lighter approach (metadata only,
not full content) would avoid the token duplication while preserving citations?
Maybe an alternative solution to avoid tool response duplication?

Screenshots or Videos

N/A - backend change only

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/21118 **Author:** [@rbb-dev](https://github.com/rbb-dev) **Created:** 2/3/2026 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix/native-fc-rag-duplication` --- ### 📝 Commits (1) - [`4b28403`](https://github.com/open-webui/open-webui/commit/4b284035a7f4bda58d2db7be3b9cbb3ba9bb8d2b) fix: skip RAG context injection for native function calling ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/utils/middleware.py` (+1 -1) </details> ### 📄 Description When native function calling is enabled, tool results are already sent to the model as function_call_output messages. However, apply_source_context_to_messages() was also injecting these same results as RAG context into user messages, causing token duplication. The fix adds a check to skip RAG context injection when function_calling is set to "native", consistent with similar checks already present for web_search, memory, and image_generation handlers. # Pull Request Checklist - [x] **Target branch:** Verify that the pull request targets the `dev` branch. - [x] **Description:** Provided above. - [x] **Changelog:** See below. - [x] **Documentation:** N/A - no docs changes needed. - [x] **Dependencies:** No new dependencies. - [x] **Testing:** Tested manually with native function calling enabled. - [x] **Agentic AI Code:** Human reviewed and tested. - [x] **Code review:** Self-reviewed. - [x] **Title Prefix:** `fix:` # Changelog Entry ### Description - Skip redundant RAG context injection when using native function calling - tool results were being sent twice (as function_call_output AND as RAG context in user messages). ### Added - N/A ### Changed - N/A ### Deprecated - N/A ### Removed - N/A ### Fixed - Tool results no longer duplicated in requests when native function calling is enabled ### Security - N/A ### Breaking Changes - N/A --- ### Additional Information - Follows the same pattern already used for web_search, memory, and image_generation handlers at lines 1573, 1580, and 1587. - Related: #19098, #20479 ### Question for Maintainers Is the RAG context injection after tool execution intentional for native function calling? If citation formatting is needed, perhaps a lighter approach (metadata only, not full content) would avoid the token duplication while preserving citations? Maybe an alternative solution to avoid tool response duplication? ### Screenshots or Videos - N/A - backend change only ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:45:46 -05:00

GiteaMirror closed this issue

2026-04-25 13:45:47 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41566