[PR #20663] [MERGED] fix: handle undefined model in createMessagePair function #41352

New Issue

GiteaMirror · 2026-04-25T13:36:50-05:00

GiteaMirror commented

2026-04-25 13:36:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20663
Author: @silentoplayz
Created: 1/14/2026
Status: ✅ Merged
Merged: 1/15/2026
Merged by: @tjbck

Base: dev ← Head: fix/create-message-pair-model-error

📝 Commits (1)

708caa9 fix: handle undefined model in createMessagePair function

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 src/lib/components/chat/Chat.svelte (+5 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Fixed a JavaScript error ("can't access property 'name', le is undefined") that occurred when using Ctrl+Shift+Enter to add a message pair in a chat with an invalid or missing model ID.

Added

User-friendly error message ("Model not found") when attempting to create a message pair with an unavailable model

Changed

Improved error handling in createMessagePair function to gracefully handle corrupt/invalid chat data

Fixed

JavaScript error in Chat.svelte when model lookup returns undefined

Additional Information

Related Issue: JavaScript error when adding message pair in corrupt chat
Affected File: src/lib/components/chat/Chat.svelte
Error Location: createMessagePair function
Root Cause: Model lookup via $models.filter((m) => m.id === modelId).at(0) returns undefined when the chat's model ID doesn't exist in available models, but the code attempted to access model.name without checking for null first.

Screenshots or Videos

Before the fix

After the fix

I have personally tested locally and confirmed:

Error no longer throws an unhandled error in the browser console.
User-friendly "Model not found" toast appears when attempting to create message pair with invalid model.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20663 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 1/14/2026 **Status:** ✅ Merged **Merged:** 1/15/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/create-message-pair-model-error` --- ### 📝 Commits (1) - [`708caa9`](https://github.com/open-webui/open-webui/commit/708caa96bb405a271c67bf8db05e688726e84a87) fix: handle undefined model in createMessagePair function ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Chat.svelte` (+5 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Fixed a JavaScript error ("can't access property 'name', le is undefined") that occurred when using `Ctrl+Shift+Enter` to add a message pair in a chat with an invalid or missing model ID. ### Added - User-friendly error message ("Model not found") when attempting to create a message pair with an unavailable model ### Changed - Improved error handling in `createMessagePair` function to gracefully handle corrupt/invalid chat data ### Fixed - JavaScript error in Chat.svelte when model lookup returns undefined --- ### Additional Information - **Related Issue:** JavaScript error when adding message pair in corrupt chat - **Affected File:** `src/lib/components/chat/Chat.svelte` - **Error Location:** `createMessagePair` function - **Root Cause:** Model lookup via `$models.filter((m) => m.id === modelId).at(0)` returns undefined when the chat's model ID doesn't exist in available models, but the code attempted to access `model.name` without checking for null first. ### Screenshots or Videos ### Before the fix <img width="2559" height="1281" alt="image" src="https://github.com/user-attachments/assets/491501fa-7b63-47ce-b0ba-385922f24caa" /> ### After the fix <img width="2559" height="1281" alt="image" src="https://github.com/user-attachments/assets/9340e590-952f-4964-88c9-6733202212ad" /> *I have personally tested locally and confirmed:* - Error no longer throws an unhandled error in the browser console. - User-friendly "Model not found" toast appears when attempting to create message pair with invalid model. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:36:50 -05:00

GiteaMirror closed this issue

2026-04-25 13:36:51 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41352