[PR #20580] [MERGED] fix(db): CRITICAL - prevent pool exhaustion in memory /reset #41315

New Issue

GiteaMirror · 2026-04-25T13:35:02-05:00

GiteaMirror commented

2026-04-25 13:35:02 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20580
Author: @Classic298
Created: 1/11/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @tjbck

Base: dev ← Head: fix/db-pool-memory-reset

📝 Commits (1)

80136fe fix(db): CRITICAL - prevent pool exhaustion in memory /reset

📊 Changes

1 file changed (+9 additions, -2 deletions)

View changed files

📝 backend/open_webui/routers/memories.py (+9 -2)

📄 Description

Remove Depends(get_session) from POST /reset to prevent catastrophic connection pool exhaustion.

This endpoint was holding a SINGLE database connection while executing N PARALLEL embedding API calls via asyncio.gather(). For a user with 100 memories, this meant one connection blocked for potentially MINUTES (100 calls * 1-5 seconds each, even in parallel due to rate limits).

A single user triggering /reset could completely starve the connection pool, causing QueuePool timeout errors across the entire application.

The Memories.get_memories_by_user_id() function now manages its own short-lived session, releasing the connection immediately before the massive parallel embedding operation begins.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20580 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 1/11/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/db-pool-memory-reset` --- ### 📝 Commits (1) - [`80136fe`](https://github.com/open-webui/open-webui/commit/80136fe3f034a4bcd576397ca4588d9e1a38762f) fix(db): CRITICAL - prevent pool exhaustion in memory /reset ### 📊 Changes **1 file changed** (+9 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/memories.py` (+9 -2) </details> ### 📄 Description Remove Depends(get_session) from POST /reset to prevent catastrophic connection pool exhaustion. This endpoint was holding a SINGLE database connection while executing N PARALLEL embedding API calls via asyncio.gather(). For a user with 100 memories, this meant one connection blocked for potentially MINUTES (100 calls * 1-5 seconds each, even in parallel due to rate limits). A single user triggering /reset could completely starve the connection pool, causing QueuePool timeout errors across the entire application. The Memories.get_memories_by_user_id() function now manages its own short-lived session, releasing the connection immediately before the massive parallel embedding operation begins. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:35:02 -05:00

GiteaMirror closed this issue

2026-04-25 13:35:03 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41315