[PR #20333] [MERGED] fix: resolve undefined knowledge base name in file reference tooltip #41201

New Issue

GiteaMirror · 2026-04-25T13:29:17-05:00

GiteaMirror commented

2026-04-25 13:29:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20333
Author: @silentoplayz
Created: 1/2/2026
Status: ✅ Merged
Merged: 1/3/2026
Merged by: @tjbck

Base: dev ← Head: fix/knowledge-tooltip

📝 Commits (1)

adff235 fix: resolve undefined knowledge base name in file reference tooltip

📊 Changes

1 file changed (+3 additions, -2 deletions)

View changed files

📝 backend/open_webui/models/knowledge.py (+3 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

Fixed a bug where the knowledge base name was missing (displayed as undefined) in the tooltip when hovering over a file reference (e.g., #filename) in the chat input. The search_knowledge_files backend endpoint now correctly includes the collection (Knowledge entity) information in its response.
This PR resolves https://github.com/open-webui/open-webui/issues/20329

Fixed

Resolved an issue where file search results in the backend were missing the associated Knowledge Base collection data, causing the frontend tooltip to display undefined > File.

Security

No security implications; properly uses existing access control checks in the query.

Additional Information

The FileUserResponse model already had a collection field, but it was not being populated in the search_knowledge_files method in backend/open_webui/models/knowledge.py. I updated the SQLAlchemy query to join the Knowledge table and populate this field.

Before

After

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20333 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 1/2/2026 **Status:** ✅ Merged **Merged:** 1/3/2026 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/knowledge-tooltip` --- ### 📝 Commits (1) - [`adff235`](https://github.com/open-webui/open-webui/commit/adff235f4a35bb62010b881cfab1e3be9fbced6e) fix: resolve undefined knowledge base name in file reference tooltip ### 📊 Changes **1 file changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/models/knowledge.py` (+3 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [x] **Description:** Provide a concise description of the changes made in this pull request down below. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [x] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description - Fixed a bug where the knowledge base name was missing (displayed as `undefined`) in the tooltip when hovering over a file reference (e.g., `#filename`) in the chat input. The `search_knowledge_files` backend endpoint now correctly includes the `collection` (Knowledge entity) information in its response. - This PR resolves https://github.com/open-webui/open-webui/issues/20329 ### Fixed - Resolved an issue where file search results in the backend were missing the associated Knowledge Base collection data, causing the frontend tooltip to display `undefined > File`. ### Security - No security implications; properly uses existing access control checks in the query. --- ### Additional Information - The `FileUserResponse` model already had a `collection` field, but it was not being populated in the `search_knowledge_files` method in `backend/open_webui/models/knowledge.py`. I updated the SQLAlchemy query to join the `Knowledge` table and populate this field. ### Before <img width="371" height="311" alt="image" src="https://github.com/user-attachments/assets/2df81e9b-5bb1-4f24-9b7c-b574ef5009f6" /> ### After <img width="371" height="311" alt="image" src="https://github.com/user-attachments/assets/94a1ae48-0431-4864-ba86-06bd128526d4" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:29:17 -05:00

GiteaMirror closed this issue

2026-04-25 13:29:18 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41201