[PR #20066] [MERGED] fix: Show DefaultFiltersSelector for global toggleable filters in model settings #41080

New Issue

GiteaMirror · 2026-04-25T13:24:17-05:00

GiteaMirror commented

2026-04-25 13:24:17 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/20066
Author: @Classic298
Created: 12/20/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @tjbck

Base: dev ← Head: filters

📝 Commits (2)

df17617 fix: Show DefaultFiltersSelector for global toggleable filters (#123)
10d02b5 Merge branch 'dev' into filters

📊 Changes

1 file changed (+14 additions, -16 deletions)

View changed files

📝 src/lib/components/workspace/Models/ModelEditor.svelte (+14 -16)

📄 Description

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- fix: Bug fix or error correction

Changelog Entry

Description

This PR fixes a bug where the DefaultFiltersSelector component in the Model Settings panel would not appear when only global toggleable filters were present (without any model-specific filters selected).

Problem:

When a filter was:
- Globally enabled (is_global=True, is_active=True)
- Toggleable (toggle=True in Python code)
- The only filter type present (no model-specific filters selected)
  Then: The DefaultFiltersSelector section would not render, preventing administrators from configuring per-model default toggle states for global filters.

Root Cause:
The DefaultFiltersSelector was wrapped in a guard condition {#if filterIds.length > 0} that checked for model-specific filters. Since global filters are not included in the filterIds array (they're automatically included via backend logic), this condition would fail even though global toggleable filters were present.

Solution:
Removed the outer filterIds.length > 0 condition, allowing the component to evaluate all toggleable filters (both model-specific via filterIds.includes(func.id) and global via func?.is_global) and render the DefaultFiltersSelector whenever any toggleable filters exist.

Impact:

Administrators can now configure default toggle states for global filters on a per-model basis
Consistent UI behavior regardless of whether toggleable filters are global or model-specific
Enables proper control over which global toggleable filters are enabled by default in the chat interface for each model

Changed

Modified src/lib/components/workspace/Models/ModelEditor.svelte (lines 732-746) to remove the restrictive outer condition preventing DefaultFiltersSelector from rendering for global toggleable filters

Removed

Removed the outer {#if filterIds.length > 0} guard condition that was preventing DefaultFiltersSelector from displaying when only global filters were present

Fixed

Fixed DefaultFiltersSelector not appearing in Model Settings when only global toggleable filters exist (without model-specific filters)
Fixed inability to configure per-model default toggle states for globally-enabled filters with toggle=True

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/20066 **Author:** [@Classic298](https://github.com/Classic298) **Created:** 12/20/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `filters` --- ### 📝 Commits (2) - [`df17617`](https://github.com/open-webui/open-webui/commit/df176173ff78eca8dc4670a07645197b15280fbd) fix: Show DefaultFiltersSelector for global toggleable filters (#123) - [`10d02b5`](https://github.com/open-webui/open-webui/commit/10d02b53aeb3d935e92de6fecfb06e202a1b44f3) Merge branch 'dev' into filters ### 📊 Changes **1 file changed** (+14 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/workspace/Models/ModelEditor.svelte` (+14 -16) </details> ### 📄 Description - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **fix**: Bug fix or error correction # Changelog Entry ### Description This PR fixes a bug where the DefaultFiltersSelector component in the Model Settings panel would not appear when only global toggleable filters were present (without any model-specific filters selected). **Problem:** - **When a filter was:** - Globally enabled (is_global=True, is_active=True) - Toggleable (toggle=True in Python code) - The only filter type present (no model-specific filters selected) **Then: The DefaultFiltersSelector section would not render, preventing administrators from configuring per-model default toggle states for global filters.** **Root Cause:** The DefaultFiltersSelector was wrapped in a guard condition {#if filterIds.length > 0} that checked for model-specific filters. Since global filters are not included in the filterIds array (they're automatically included via backend logic), this condition would fail even though global toggleable filters were present. **Solution:** Removed the outer filterIds.length > 0 condition, allowing the component to evaluate all toggleable filters (both model-specific via filterIds.includes(func.id) and global via func?.is_global) and render the DefaultFiltersSelector whenever any toggleable filters exist. **Impact:** - Administrators can now configure default toggle states for global filters on a per-model basis - Consistent UI behavior regardless of whether toggleable filters are global or model-specific - Enables proper control over which global toggleable filters are enabled by default in the chat interface for each model ### Changed Modified src/lib/components/workspace/Models/ModelEditor.svelte (lines 732-746) to remove the restrictive outer condition preventing DefaultFiltersSelector from rendering for global toggleable filters ### Removed Removed the outer {#if filterIds.length > 0} guard condition that was preventing DefaultFiltersSelector from displaying when only global filters were present ### Fixed - Fixed DefaultFiltersSelector not appearing in Model Settings when only global toggleable filters exist (without model-specific filters) - Fixed inability to configure per-model default toggle states for globally-enabled filters with toggle=True ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:24:17 -05:00

GiteaMirror closed this issue

2026-04-25 13:24:19 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41080