[PR #19959] [MERGED] fix: user group pagination reset and model image caching #41042

New Issue

GiteaMirror · 2026-04-25T13:22:07-05:00

GiteaMirror commented

2026-04-25 13:22:07 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19959
Author: @silentoplayz
Created: 12/15/2025
Status: ✅ Merged
Merged: 12/21/2025
Merged by: @tjbck

Base: dev ← Head: fix/issue-19885-group-users-and-model-image

📝 Commits (1)

cd953cb fix: user group pagination reset and model image caching

📊 Changes

2 files changed (+12 additions, -6 deletions)

View changed files

📝 backend/open_webui/routers/models.py (+10 -4)
📝 src/lib/components/admin/Users/Groups/Users.svelte (+2 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR fixes two separate bugs reported in issue #19885:

User Group Selection Bug: In "Edit User Group", the user list would reset to page 1 and reshuffle (due to sorting by group membership) whenever a user was selected/deselected. This made it increasingly hard to bulk-add users from pagination pages beyond page 1.
Model Image Display Bug: Custom model avatar images were not updating in the chat interface due to aggressive browser caching of the profile/image endpoint, unless cache were manually reset for the page using CTRL+F5 a few times.

Added

Added Cache-Control: no-cache, must-revalidate headers to the get_model_profile_image endpoint to prevent serving stale cached avatars. During my testing, the model's avatars (when set or changed) would update after a page refresh instead of necessitating a reset of the page's cache.

Changed

Changed default sort order in "Edit User Group" modal from group_id (membership status) to created_at (newest first). This prevents the list from re-ordering immediately when a user's membership status toggles.
Updated setSortKey in Users.svelte to reset pagination to page 1 only when the sort order is explicitly changed by the user.

Removed

Removed the explicit page = 1 reset in the toggleMember function in Users.svelte to preserve the admin's current page while selecting users.

Fixed

Fixed user group selection resetting pagination and list order: Users can now select/deselect multiple users on any page without losing their place.
Semi-fixed model avatar images not updating in admin models list.

Additional Information

Related Issue: #19885

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19959 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 12/15/2025 **Status:** ✅ Merged **Merged:** 12/21/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/issue-19885-group-users-and-model-image` --- ### 📝 Commits (1) - [`cd953cb`](https://github.com/open-webui/open-webui/commit/cd953cb5e3d26506bc93e3ab4fc311817459f253) fix: user group pagination reset and model image caching ### 📊 Changes **2 files changed** (+12 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/models.py` (+10 -4) 📝 `src/lib/components/admin/Users/Groups/Users.svelte` (+2 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work Changelog Entry Description This PR fixes two separate bugs reported in issue #19885: 1. **User Group Selection Bug:** In "Edit User Group", the user list would reset to page 1 and reshuffle (due to sorting by group membership) whenever a user was selected/deselected. This made it increasingly hard to bulk-add users from pagination pages beyond page 1. 2. **Model Image Display Bug:** Custom model avatar images were not updating in the chat interface due to aggressive browser caching of the `profile/image` endpoint, unless cache were manually reset for the page using `CTRL+F5` a few times. Added - Added `Cache-Control: no-cache, must-revalidate` headers to the `get_model_profile_image` endpoint to prevent serving stale cached avatars. During my testing, the model's avatars (when set or changed) would update after a page refresh instead of necessitating a reset of the page's cache. Changed - Changed default sort order in "Edit User Group" modal from `group_id (membership status)` to `created_at (newest first)`. This prevents the list from re-ordering immediately when a user's membership status toggles. - Updated `setSortKey` in `Users.svelte` to reset pagination to page 1 only when the sort order is explicitly changed by the user. Removed - Removed the explicit `page = 1` reset in the `toggleMember` function in `Users.svelte` to preserve the admin's current page while selecting users. Fixed - Fixed user group selection resetting pagination and list order: Users can now select/deselect multiple users on any page without losing their place. - Semi-fixed model avatar images not updating in admin models list. Additional Information Related Issue: #19885 ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:22:07 -05:00

GiteaMirror closed this issue

2026-04-25 13:22:08 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41042