[PR #19948] [CLOSED] feat: enhance memory system with user-controllable toggles #41038

New Issue

GiteaMirror · 2026-04-25T13:21:50-05:00

GiteaMirror commented

2026-04-25 13:21:50 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/19948
Author: @silentoplayz
Created: 12/14/2025
Status: ❌ Closed

Base: dev ← Head: memory-settings-clean

📝 Commits (2)

e71a031 feat: auto memory toggle
1cab9dc feat: Memory feature revamp

📊 Changes

6 files changed (+297 additions, -34 deletions)

View changed files

📝 backend/open_webui/routers/chats.py (+35 -3)
📝 backend/open_webui/utils/chat.py (+133 -1)
📝 backend/open_webui/utils/middleware.py (+28 -3)
📝 src/lib/apis/index.ts (+1 -1)
📝 src/lib/components/chat/Chat.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Personalization.svelte (+99 -25)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.

This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.

Before submitting, make sure you've checked the following:

Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
Description: Provide a concise description of the changes made in this pull request down below.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR enhances the Memory feature with granular user controls, allowing users to fine-tune how memories are used and created. Previously, the memory system only had a single toggle with automatic retrieval always enabled. This update adds:

Active Memory Recall toggle - Control whether stored memories are injected into chat context
Inject Profile Info toggle - Include user's name, bio, and gender in chat context as memory
Automatic Memory Creation toggle - Enable/disable automatic extraction of memories from conversations
Custom Memory Extraction Prompt - Define how the LLM should extract and format memories
These settings are placed in the Personalization section of User Settings, integrating naturally with existing personalization options.

Added

Active Memory Recall toggle in Personalization settings - enables/disables memory injection during chat
Inject Profile Info toggle - injects user account info (name, bio, gender) into chat context
Automatic Memory Creation toggle - enables automatic memory extraction after chat completion
Memory Extraction Prompt textarea - allows custom prompt for memory extraction format chat_memory_handler in middleware.py now supports profile info injection /chats/completed endpoint for post-chat processing (memory extraction)

Changed

Memory feature now requires both main Memory toggle AND Active Memory Recall to be enabled for memory injection.
Improved default memory extraction prompt to use third-person format (e.g., "Prefers concise responses" instead of "User prefers concise responses")
Memory settings conditionally render only when the main Memory toggle is enabled

Deprecated

[List any deprecated functionality or features that have been removed]

Removed

Removed dead code: unused get_memory_topics function from
chat.py
Removed duplicate memory retrieval logic from generate_chat_completion (now handled exclusively by middleware)

Fixed

Fixed missing await on async embedding function calls that would cause vector DB upsert failures
Fixed embedding function in memory search that was not properly awaited

Security

[List any new or updated security-related changes, including vulnerability fixes]

Breaking Changes

BREAKING CHANGE: [List any breaking changes affecting compatibility or functionality]

Additional Information

This builds on the existing experimental Memory system, adding user-controllable granularity
Profile info injection uses only non-sensitive fields (name, bio, gender) and requires explicit user opt-in.
Memory retrieval is handled in middleware.py via chat_memory_handler.
Automatic memory creation is handled in chat.py via chat_completed.

Screenshots or Videos

Screencast from 2025-12-14 10-53-27.webm

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/19948 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 12/14/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `memory-settings-clean` --- ### 📝 Commits (2) - [`e71a031`](https://github.com/open-webui/open-webui/commit/e71a031b8dbef6e057b998188e3cdfcc7fbe810a) feat: auto memory toggle - [`1cab9dc`](https://github.com/open-webui/open-webui/commit/1cab9dcdaecbc812cb4ae255e055f60418e796e0) feat: Memory feature revamp ### 📊 Changes **6 files changed** (+297 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/chats.py` (+35 -3) 📝 `backend/open_webui/utils/chat.py` (+133 -1) 📝 `backend/open_webui/utils/middleware.py` (+28 -3) 📝 `src/lib/apis/index.ts` (+1 -1) 📝 `src/lib/components/chat/Chat.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Personalization.svelte` (+99 -25) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request. This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Verify that the pull request targets the `dev` branch. **Not targeting the `dev` branch will lead to immediate closure of the PR.** - [X] **Description:** Provide a concise description of the changes made in this pull request down below. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** If necessary, update relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs) like environment variables, the tutorials, or other documentation sources. - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Perform manual tests to **verify the implemented fix/feature works as intended AND does not break any other functionality**. Take this as an opportunity to **make screenshots of the feature/fix and include it in the PR description**. - [X] **Agentic AI Code:** Confirm this Pull Request is **not written by any AI Agent** or has at least **gone through additional human review AND manual testing**. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR. - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Title Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This PR enhances the Memory feature with granular user controls, allowing users to fine-tune how memories are used and created. Previously, the memory system only had a single toggle with automatic retrieval always enabled. This update adds: **Active Memory Recall** toggle - Control whether stored memories are injected into chat context **Inject Profile Info** toggle - Include user's name, bio, and gender in chat context as memory **Automatic Memory Creation** toggle - Enable/disable automatic extraction of memories from conversations **Custom Memory Extraction Prompt** - Define how the LLM should extract and format memories These settings are placed in the Personalization section of User Settings, integrating naturally with existing personalization options. ### Added - `Active Memory Recall` toggle in Personalization settings - enables/disables memory injection during chat - `Inject Profile Info` toggle - injects user account info (name, bio, gender) into chat context - `Automatic Memory Creation` toggle - enables automatic memory extraction after chat completion - `Memory Extraction Prompt` textarea - allows custom prompt for memory extraction format `chat_memory_handler` in `middleware.py` now supports profile info injection `/chats/completed` endpoint for post-chat processing (memory extraction) ### Changed - Memory feature now requires both main Memory toggle AND `Active Memory Recall` to be enabled for memory injection. - Improved default memory extraction prompt to use third-person format (e.g., "Prefers concise responses" instead of "User prefers concise responses") - Memory settings conditionally render only when the main Memory toggle is enabled ### Deprecated - [List any deprecated functionality or features that have been removed] ### Removed - Removed dead code: unused get_memory_topics function from chat.py - Removed duplicate memory retrieval logic from `generate_chat_completion` (now handled exclusively by middleware) ### Fixed - Fixed missing await on `async` embedding function calls that would cause vector DB upsert failures - Fixed embedding function in memory search that was not properly awaited ### Security - [List any new or updated security-related changes, including vulnerability fixes] ### Breaking Changes - **BREAKING CHANGE**: [List any breaking changes affecting compatibility or functionality] --- ### Additional Information - This builds on the existing experimental Memory system, adding user-controllable granularity - Profile info injection uses only non-sensitive fields (name, bio, gender) and requires explicit user opt-in. - Memory retrieval is handled in `middleware.py` via `chat_memory_handler`. - Automatic memory creation is handled in `chat.py` via `chat_completed`. ### Screenshots or Videos [Screencast from 2025-12-14 10-53-27.webm](https://github.com/user-attachments/assets/6345412d-9071-4ee8-bfda-7cf3bb536c59) <img width="1375" height="777" alt="image" src="https://github.com/user-attachments/assets/1a18f33d-b2ff-4fb7-8053-7139bfcb2e4b" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](https://github.com/open-webui/open-webui/blob/main/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. > [!NOTE] > Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 13:21:50 -05:00

GiteaMirror closed this issue

2026-04-25 13:21:52 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#41038