github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-07-16 06:03:26 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #18850] [CLOSED] refactor(retrieval): remove duplicate MistralLoader code block #40627

New Issue
Closed
opened 2026-04-25 13:05:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 13:05:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/18850
Author: @fsmw
Created: 11/1/2025
Status: ❌ Closed

Base: main ← Head: fix/17256-duplicate-external-document-loader-entry

📝 Commits (1)

  • 4d50829 refactor(retrieval): remove duplicate MistralLoader code block

📊 Changes

1 file changed (+0 additions, -9 deletions)

View changed files

📝 backend/open_webui/retrieval/loaders/main.py (+0 -9)

📄 Description

Summary

Remove duplicate MistralLoader code block with incorrect conditional logic in document loader main.py.

Issue

Fixes #17256 - Duplicate external document loader entry

Changes Made

  • Removed duplicate MistralLoader block (lines 364-372)
  • Kept the correct MistralLoader implementation
  • Cleaned up incorrect conditional logic

Testing

  • Verified duplicate code block existed
  • Confirmed removal doesn't break functionality
  • Tested document loading with various file types

Additional Information

This refactor removes code duplication and incorrect loader assignment that could cause issues with document processing.

I agree to the terms of the Contributor License Agreement (CLA) and grant the necessary rights for my contributions to be included in this open-source project.

💘 Generated with Crush

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/18850 **Author:** [@fsmw](https://github.com/fsmw) **Created:** 11/1/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/17256-duplicate-external-document-loader-entry` --- ### 📝 Commits (1) - [`4d50829`](https://github.com/open-webui/open-webui/commit/4d5082976ebb0486b781e7c9266632856c8d5c6c) refactor(retrieval): remove duplicate MistralLoader code block ### 📊 Changes **1 file changed** (+0 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/retrieval/loaders/main.py` (+0 -9) </details> ### 📄 Description ## Summary Remove duplicate MistralLoader code block with incorrect conditional logic in document loader main.py. ## Issue Fixes #17256 - Duplicate external document loader entry ## Changes Made - [x] Removed duplicate MistralLoader block (lines 364-372) - [x] Kept the correct MistralLoader implementation - [x] Cleaned up incorrect conditional logic ## Testing - [x] Verified duplicate code block existed - [x] Confirmed removal doesn't break functionality - [x] Tested document loading with various file types ## Additional Information This refactor removes code duplication and incorrect loader assignment that could cause issues with document processing. I agree to the terms of the Contributor License Agreement (CLA) and grant the necessary rights for my contributions to be included in this open-source project. 💘 Generated with Crush --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 13:05:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#40627
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?