[PR #16249] [MERGED] fix(frontend): Attempt to resolve TypeError in RichTextInput.svelte #39711

New Issue

GiteaMirror · 2026-04-25T12:11:41-05:00

GiteaMirror commented

2026-04-25 12:11:41 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16249
Author: @silentoplayz
Created: 8/4/2025
Status: ✅ Merged
Merged: 8/4/2025
Merged by: @tjbck

Base: dev ← Head: fix-richtext-getwordatdocpos

📝 Commits (2)

7a80e60 fix(frontend): Attempt to resolve TypeError in RichTextInput.svelte
55d3c07 revert: Reverts requested

📊 Changes

7 files changed (+20 additions, -20 deletions)

View changed files

📝 src/lib/apis/index.ts (+4 -4)
📝 src/lib/apis/ollama/index.ts (+1 -1)
📝 src/lib/apis/users/index.ts (+1 -1)
📝 src/lib/i18n/index.ts (+2 -2)
📝 src/lib/utils/characters/index.ts (+5 -5)
📝 src/lib/utils/marked/katex-extension.ts (+6 -6)
📝 src/lib/workers/pyodide.worker.ts (+1 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

This pull request addresses a potential TypeError in MessageInput.svelte related to getWordAtDocPos not being a function. The changes aim to ensure that the getWordAtDocPos function, which is now provided by the RichTextInput component, is correctly referenced and called.

Changelog Entry

Description

This pull request attempts to fix a TypeError (ue.getWordAtDocPos is not a function) that occurs in MessageInput.svelte when a production instance of Open WebUI is restarted, and the user remains on the same page without refreshing. The issue is difficult to reproduce in a development environment due to hot-reloading. The changes involve refactoring how getWordAtDocPos is accessed, ensuring that the function is properly passed and used from the RichTextInput component.

Changed

In MessageInput.svelte:
- Updated the call from chatInputElementType?.getWordAtDocPos() to getWordAtDocPosFromRichText(), to properly access the function provided by RichTextInput.
- Added a new getWordAtDocPosFromRichText variable initialized to an empty string, which will be updated via a callback from RichTextInput.
- Modified the RichTextInput component instantiation to pass a new getWordAtDocPosCallback prop.
In RichTextInput.svelte:
- Exported a new getWordAtDocPosCallback function which accepts a function (func) and assigns it to getWordAtDocPosFromRichText.
- Called getWordAtDocPosCallback with the internal getWordAtDocPos function to provide it to the parent component.

Fixed

Potentially fixed TypeError: ue.getWordAtDocPos is not a function by ensuring MessageInput.svelte correctly receives and uses the getWordAtDocPos function from RichTextInput.svelte via a callback mechanism.

Additional Information

The specific error triggering condition (production restart without page refresh) makes it challenging to definitively confirm the fix in a development environment.
The approach taken is to use a callback (getWordAtDocPosCallback) to pass the getWordAtDocPos function from RichTextInput (the component that knows how to get the word at the document position) up to MessageInput, which needs to call it. This avoids direct reliance on the chatInputElementType which seemed to lose its methods after a restart.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16249 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 8/4/2025 **Status:** ✅ Merged **Merged:** 8/4/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix-richtext-getwordatdocpos` --- ### 📝 Commits (2) - [`7a80e60`](https://github.com/open-webui/open-webui/commit/7a80e607851fea369c7f8155a78959e44baebe2f) fix(frontend): Attempt to resolve TypeError in RichTextInput.svelte - [`55d3c07`](https://github.com/open-webui/open-webui/commit/55d3c07d85f23fc6a2291adc2699667ff7b1579f) revert: Reverts requested ### 📊 Changes **7 files changed** (+20 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/apis/index.ts` (+4 -4) 📝 `src/lib/apis/ollama/index.ts` (+1 -1) 📝 `src/lib/apis/users/index.ts` (+1 -1) 📝 `src/lib/i18n/index.ts` (+2 -2) 📝 `src/lib/utils/characters/index.ts` (+5 -5) 📝 `src/lib/utils/marked/katex-extension.ts` (+6 -6) 📝 `src/lib/workers/pyodide.worker.ts` (+1 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work This pull request addresses a potential `TypeError` in `MessageInput.svelte` related to `getWordAtDocPos` not being a function. The changes aim to ensure that the `getWordAtDocPos` function, which is now provided by the `RichTextInput` component, is correctly referenced and called. # Changelog Entry ### Description This pull request attempts to fix a `TypeError` (`ue.getWordAtDocPos is not a function`) that occurs in `MessageInput.svelte` when a production instance of Open WebUI is restarted, and the user remains on the same page without refreshing. The issue is difficult to reproduce in a development environment due to hot-reloading. The changes involve refactoring how `getWordAtDocPos` is accessed, ensuring that the function is properly passed and used from the `RichTextInput` component. ### Changed - In `MessageInput.svelte`: - Updated the call from `chatInputElementType?.getWordAtDocPos()` to `getWordAtDocPosFromRichText()`, to properly access the function provided by `RichTextInput`. - Added a new `getWordAtDocPosFromRichText` variable initialized to an empty string, which will be updated via a callback from `RichTextInput`. - Modified the `RichTextInput` component instantiation to pass a new `getWordAtDocPosCallback` prop. - In `RichTextInput.svelte`: - Exported a new `getWordAtDocPosCallback` function which accepts a function (`func`) and assigns it to `getWordAtDocPosFromRichText`. - Called `getWordAtDocPosCallback` with the internal `getWordAtDocPos` function to provide it to the parent component. ### Fixed - Potentially fixed `TypeError: ue.getWordAtDocPos is not a function` by ensuring `MessageInput.svelte` correctly receives and uses the `getWordAtDocPos` function from `RichTextInput.svelte` via a callback mechanism. --- ### Additional Information - The specific error triggering condition (production restart without page refresh) makes it challenging to definitively confirm the fix in a development environment. - The approach taken is to use a callback (`getWordAtDocPosCallback`) to pass the `getWordAtDocPos` function from `RichTextInput` (the component that knows how to get the word at the document position) up to `MessageInput`, which needs to call it. This avoids direct reliance on the `chatInputElementType` which seemed to lose its methods after a restart. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 12:11:41 -05:00

GiteaMirror closed this issue

2026-04-25 12:11:43 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39711