[PR #16174] [CLOSED] feat: user menu tab order and menu item accessibility #39681

Closed
opened 2026-04-25 12:10:38 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16174
Author: @sinejespersen
Created: 7/31/2025
Status: Closed

Base: devHead: feature/user-menu-tab-order-and-menu-item-accessibility


📝 Commits (3)

  • 30218a6 remove duplicate button in user menu to improve tab order
  • 77babb6 add aria label, make alt text translatable
  • 05428f8 use bits-ui dropdownmenu item to make menu items focusable

📊 Changes

2 files changed (+20 additions, -25 deletions)

View changed files

📝 src/lib/components/layout/Sidebar.svelte (+4 -7)
📝 src/lib/components/layout/Sidebar/UserMenu.svelte (+16 -18)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Improve accessibility by making user profile usable with keyboard tabs.

Added

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A


Additional Information

N/A

Screenshots or Videos

Incorrect tab order - BEFORE

tab-order-incorrect

Correct tab order - AFTER

tab-correct

Impossible to tab - BEFORE

tab-impossible-in-menu

Possible to tab - AFTER

tab-order-possible

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16174 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 7/31/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `feature/user-menu-tab-order-and-menu-item-accessibility` --- ### 📝 Commits (3) - [`30218a6`](https://github.com/open-webui/open-webui/commit/30218a6db0e1b6e32f8265e46198eeed60663eb2) remove duplicate button in user menu to improve tab order - [`77babb6`](https://github.com/open-webui/open-webui/commit/77babb6b63fabace754364c8db86e77cc1035f99) add aria label, make alt text translatable - [`05428f8`](https://github.com/open-webui/open-webui/commit/05428f8180de7d9e520970e52aa45b3f181294eb) use bits-ui dropdownmenu item to make menu items focusable ### 📊 Changes **2 files changed** (+20 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/layout/Sidebar.svelte` (+4 -7) 📝 `src/lib/components/layout/Sidebar/UserMenu.svelte` (+16 -18) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [ ] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [ ] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Improve accessibility by making user profile usable with keyboard tabs. ### Added - User menu items use [bits-ui dropdown menu item](https://www.bits-ui.com/docs/components/dropdown-menu) - Remove button to make reduce amounts of tab to react user menu ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos **Incorrect tab order - BEFORE** ![tab-order-incorrect](https://github.com/user-attachments/assets/d5ce9942-a16b-47f3-8350-5a3018ac727d) **Correct tab order - AFTER** ![tab-correct](https://github.com/user-attachments/assets/b097b4dc-cdcc-4c08-8de2-55cfd66b8e93) **Impossible to tab - BEFORE** ![tab-impossible-in-menu](https://github.com/user-attachments/assets/9c2bda7f-6df3-4989-ab7f-db028a894578) **Possible to tab - AFTER** ![tab-order-possible](https://github.com/user-attachments/assets/8f32e6a4-30a9-4f99-8f1d-6aa539cc116f) ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 12:10:38 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#39681