[PR #16118] [CLOSED] fix: pinned models reorganization #39666

New Issue

GiteaMirror · 2026-04-25T12:10:10-05:00

GiteaMirror commented

2026-04-25 12:10:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/16118
Author: @silentoplayz
Created: 7/29/2025
Status: ❌ Closed

Base: dev ← Head: fix-pinned-models-reorganization

📝 Commits (2)

bfead81 fix: pinned models reorganization
0905f0b fix: Idk anymore. Might not be a good PR.

📊 Changes

3 files changed (+26 additions, -30 deletions)

View changed files

📝 src/lib/components/common/Folder.svelte (+3 -16)
📝 src/lib/components/layout/Sidebar.svelte (+10 -3)
📝 src/lib/components/layout/Sidebar/ChatItem.svelte (+13 -11)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request addresses a bug that caused the browser to misinterpret the drag-and-drop reordering of pinned models as a file drop event. This resulted in an "Invalid file format" error in some browsers and prevented the feature from working correctly.
Related merged PR: https://github.com/open-webui/open-webui/pull/16115

Fixed

Drag-and-Drop Reordering: Hopefully fixed a bug where reordering pinned models would trigger a file drop event, preventing the reordering from working as intended. The onDrop event handler has been updated to specifically check for file drops, and the SortableJS configuration now correctly handles the drag start event to avoid conflicts with the browser's native drag-and-drop functionality.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/16118 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 7/29/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `fix-pinned-models-reorganization` --- ### 📝 Commits (2) - [`bfead81`](https://github.com/open-webui/open-webui/commit/bfead8184b21e100239fd6c2be9931470409c108) fix: pinned models reorganization - [`0905f0b`](https://github.com/open-webui/open-webui/commit/0905f0bc20c9c2b47ec06e9597efe3db4ac608cd) fix: Idk anymore. Might not be a good PR. ### 📊 Changes **3 files changed** (+26 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/common/Folder.svelte` (+3 -16) 📝 `src/lib/components/layout/Sidebar.svelte` (+10 -3) 📝 `src/lib/components/layout/Sidebar/ChatItem.svelte` (+13 -11) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [X] **Target branch:** Please verify that the pull request targets the `dev` branch. - [X] **Description:** Provide a concise description of the changes made in this pull request. - [X] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [X] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [X] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [X] **Testing:** Have you written and run sufficient tests to validate the changes? - [X] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [X] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request addresses a bug that caused the browser to misinterpret the drag-and-drop reordering of pinned models as a file drop event. This resulted in an "Invalid file format" error in some browsers and prevented the feature from working correctly. - Related merged PR: https://github.com/open-webui/open-webui/pull/16115 ### Fixed - **Drag-and-Drop Reordering:** ***Hopefully*** fixed a bug where reordering pinned models would trigger a file drop event, preventing the reordering from working as intended. The `onDrop` event handler has been updated to specifically check for file drops, and the `SortableJS` configuration now correctly handles the drag start event to avoid conflicts with the browser's native drag-and-drop functionality. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 12:10:10 -05:00

GiteaMirror closed this issue

2026-04-25 12:10:11 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39666