[PR #15842] [MERGED] fix: deleting files from vector DB upon file deletion #39588

New Issue

GiteaMirror · 2026-04-25T12:07:47-05:00

GiteaMirror commented

2026-04-25 12:07:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15842
Author: @expruc
Created: 7/18/2025
Status: ✅ Merged
Merged: 7/19/2025
Merged by: @tjbck

Base: dev ← Head: fix/handle_remove_files_from_vdb

📝 Commits (1)

30a079c added handler for deleting files from vdb upon files deletion

📊 Changes

1 file changed (+3 additions, -1 deletions)

View changed files

📝 backend/open_webui/routers/files.py (+3 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This PR handles deleting files from vector DB using the file deletion API (/api/v1/files/all and /api/v1/files/{id}). Previously, deleting files from delete files API didn't delete the entries from the vector DB (chroma/external one), which is now fixed.

Fixed

Deleting files from API now deletes entries from vector DB

Additional Information

Deleting one file deletes the respective collection (which is named <prefix>_file-{id}) from the vector DB
Deleting all files deletes all the collections from the vector DB (including the knowledge collection), which is equivalent to reseting the vector DB. The collections are recreated upon file upload through API/UI.
I have tested this with both qdrant and chroma vector DB. The following works with uploading/deleting files from both UI and API as expected.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15842 **Author:** [@expruc](https://github.com/expruc) **Created:** 7/18/2025 **Status:** ✅ Merged **Merged:** 7/19/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `fix/handle_remove_files_from_vdb` --- ### 📝 Commits (1) - [`30a079c`](https://github.com/open-webui/open-webui/commit/30a079cba8822e6094f23253f0b972e807a7f946) added handler for deleting files from vdb upon files deletion ### 📊 Changes **1 file changed** (+3 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/routers/files.py` (+3 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description This PR handles deleting files from vector DB using the file deletion API (`/api/v1/files/all and /api/v1/files/{id}`). Previously, deleting files from delete files API didn't delete the entries from the vector DB (chroma/external one), which is now fixed. ### Fixed - Deleting files from API now deletes entries from vector DB --- ### Additional Information - Deleting one file deletes the respective collection (which is named `<prefix>_file-{id}`) from the vector DB - Deleting all files deletes all the collections from the vector DB (including the knowledge collection), which is equivalent to reseting the vector DB. The collections are recreated upon file upload through API/UI. I have tested this with both qdrant and chroma vector DB. The following works with uploading/deleting files from both UI and API as expected. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 12:07:47 -05:00

GiteaMirror closed this issue

2026-04-25 12:07:48 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39588