[PR #15344] [MERGED] fix: A couple small fixes #39428

New Issue

GiteaMirror · 2026-04-25T12:01:19-05:00

GiteaMirror commented

2026-04-25 12:01:19 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15344
Author: @silentoplayz
Created: 6/27/2025
Status: ✅ Merged
Merged: 6/27/2025
Merged by: @tjbck

Base: dev ← Head: small-fixes

📝 Commits (1)

e3bacc3 fix: Small fixes

📊 Changes

7 files changed (+7 additions, -5 deletions)

View changed files

📝 scripts/prepare-pyodide.js (+2 -2)
📝 src/lib/apis/users/index.ts (+1 -0)
📝 src/lib/components/admin/Settings/WebSearch.svelte (+0 -1)
📝 src/lib/components/chat/MessageInput/CallOverlay.svelte (+1 -0)
📝 src/lib/components/common/Modal.svelte (+1 -0)
📝 src/lib/i18n/index.ts (+1 -1)
📝 src/routes/+error.svelte (+1 -1)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

This pull request consolidates several minor improvements, bug fixes, and code cleanups across different parts of the application. Key changes include enhanced error logging, more robust handling of i18n loading states, prevention of potential errors on the error page, and an update to the user profile image field.

Added

Added role to the UserUpdateForm type definition in src/lib/apis/users/index.ts.

Changed

Improved error logging in scripts/prepare-pyodide.js by including the err object in the console output for better debugging.
Minor code cleanup in src/lib/components/admin/Settings/WebSearch.svelte by removing an unnecessary period.
Added  to src/lib/components/chat/MessageInput/CallOverlay.svelte to suppress an accessibility warning related to video elements without explicit captions.
Added  to src/lib/components/common/Modal.svelte to explicitly acknowledge and suppress an accessibility warning when using event handlers on non-interactive elements.
Refactored the i18n loading state logic in src/lib/i18n/index.ts for a more explicit and potentially robust determination of the isLoading state.

Fixed

Implemented optional chaining (?.) for $page.error.message in src/routes/+error.svelte to prevent a potential runtime error if $page.error is null or undefined.

Additional Information

These changes primarily focus on code quality, minor bug prevention, and extending the user update functionality.

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15344 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/27/2025 **Status:** ✅ Merged **Merged:** 6/27/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `small-fixes` --- ### 📝 Commits (1) - [`e3bacc3`](https://github.com/open-webui/open-webui/commit/e3bacc329657ba1deec2ebcfdbd194ad42caf650) fix: Small fixes ### 📊 Changes **7 files changed** (+7 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `scripts/prepare-pyodide.js` (+2 -2) 📝 `src/lib/apis/users/index.ts` (+1 -0) 📝 `src/lib/components/admin/Settings/WebSearch.svelte` (+0 -1) 📝 `src/lib/components/chat/MessageInput/CallOverlay.svelte` (+1 -0) 📝 `src/lib/components/common/Modal.svelte` (+1 -0) 📝 `src/lib/i18n/index.ts` (+1 -1) 📝 `src/routes/+error.svelte` (+1 -1) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - This pull request consolidates several minor improvements, bug fixes, and code cleanups across different parts of the application. Key changes include enhanced error logging, more robust handling of i18n loading states, prevention of potential errors on the error page, and an update to the user profile image field. ### Added - Added `role` to the `UserUpdateForm` type definition in `src/lib/apis/users/index.ts`. ### Changed - Improved error logging in `scripts/prepare-pyodide.js` by including the `err` object in the console output for better debugging. - Minor code cleanup in `src/lib/components/admin/Settings/WebSearch.svelte` by removing an unnecessary period. - Added `` to `src/lib/components/chat/MessageInput/CallOverlay.svelte` to suppress an accessibility warning related to video elements without explicit captions. - Added `` to `src/lib/components/common/Modal.svelte` to explicitly acknowledge and suppress an accessibility warning when using event handlers on non-interactive elements. - Refactored the i18n loading state logic in `src/lib/i18n/index.ts` for a more explicit and potentially robust determination of the `isLoading` state. ### Fixed - Implemented optional chaining (`?.`) for `$page.error.message` in `src/routes/+error.svelte` to prevent a potential runtime error if `$page.error` is null or undefined. --- ### Additional Information - These changes primarily focus on code quality, minor bug prevention, and extending the user update functionality. ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 12:01:19 -05:00

GiteaMirror closed this issue

2026-04-25 12:01:24 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39428