github-starred/open-webui
2
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-06-03 15:27:37 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #15141] [CLOSED] fix: Enhance database migration error logging #39361

New Issue
Closed
opened 2026-04-25 11:58:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-25 11:58:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15141
Author: @jackthgu
Created: 6/19/2025
Status: ❌ Closed

Base: main ← Head: none-dbconnect-warning-message

📝 Commits (10+)

  • a7772b4 Italian translation improved
  • 8572494 Update Controls.svelte
  • 9f936a0 Update General.svelte
  • 4f9ce28 Update ChatPlaceholder.svelte
  • 9d37350 Update Markdown.svelte
  • f7920df Fix non-ascii error issue on ENABLE_FORWARD_USER_INFO_HEADERS
  • 8a63a60 Fix typo on ollama patch
  • 135b57c Update Placeholder.svelte
  • c8c4e16 Merge branch 'open-webui:main' into correct-markdown-rendering-model-descriptions
  • beb1f3f Merge branch 'open-webui:main' into system-prompt-resizing

📊 Changes

36 files changed (+1547 additions, -1403 deletions)

View changed files

📝 backend/open_webui/env.py (+5 -0)
📝 backend/open_webui/internal/db.py (+4 -0)
📝 backend/open_webui/retrieval/utils.py (+13 -12)
📝 backend/open_webui/routers/audio.py (+14 -9)
📝 backend/open_webui/routers/files.py (+8 -7)
📝 backend/open_webui/routers/images.py (+5 -4)
📝 backend/open_webui/routers/ollama.py (+37 -36)
📝 backend/open_webui/routers/openai.py (+29 -29)
📝 backend/open_webui/routers/retrieval.py (+10 -0)
📝 backend/open_webui/utils/chat.py (+1 -1)
📝 backend/open_webui/utils/telemetry/setup.py (+17 -1)
📝 pyproject.toml (+1 -1)
📝 src/lib/apis/auths/index.ts (+2 -0)
📝 src/lib/apis/index.ts (+2 -1)
📝 src/lib/components/AddServerModal.svelte (+47 -14)
📝 src/lib/components/chat/Chat.svelte (+6 -6)
📝 src/lib/components/chat/ChatPlaceholder.svelte (+2 -2)
📝 src/lib/components/chat/Controls/Controls.svelte (+1 -1)
📝 src/lib/components/chat/Messages/Markdown.svelte (+2 -1)
📝 src/lib/components/chat/Placeholder.svelte (+8 -4)

...and 16 more files

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Please verify that the pull request targets the dev branch.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Have you written and run sufficient tests to validate the changes?
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • Enhances the error message during Peewee database migrations to provide users with a helpful hint for troubleshooting connection failures.

Added

  • None

Changed

  • The handle_peewee_migration function in backend/open_webui/internal/db.py now logs a warning message suggesting that special characters in the database password should be URL-encoded if the connection fails.

Deprecated

  • None

Removed

  • None

Fixed

  • Improves the user experience by providing clearer guidance for resolving a common database connection issue related to special characters in passwords.

Security

  • None

Breaking Changes

  • BREAKING CHANGE: None

Additional Information

  • None

Screenshots or Videos

  • None

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15141 **Author:** [@jackthgu](https://github.com/jackthgu) **Created:** 6/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `none-dbconnect-warning-message` --- ### 📝 Commits (10+) - [`a7772b4`](https://github.com/open-webui/open-webui/commit/a7772b4b35b4ccc68c25085a23c95b946cbf8b4c) Italian translation improved - [`8572494`](https://github.com/open-webui/open-webui/commit/85724940ee9870981bad735b76dc2526088aca96) Update Controls.svelte - [`9f936a0`](https://github.com/open-webui/open-webui/commit/9f936a0c19491b9e1a2adf00c7b81ad0dd58a67f) Update General.svelte - [`4f9ce28`](https://github.com/open-webui/open-webui/commit/4f9ce28a15736876d4b4a6a590210bf364ce45bc) Update ChatPlaceholder.svelte - [`9d37350`](https://github.com/open-webui/open-webui/commit/9d37350b97917df296c662c8a33564bdd78c04ed) Update Markdown.svelte - [`f7920df`](https://github.com/open-webui/open-webui/commit/f7920df8707af24d59a0c7a03266742743be2562) Fix non-ascii error issue on ENABLE_FORWARD_USER_INFO_HEADERS - [`8a63a60`](https://github.com/open-webui/open-webui/commit/8a63a601de7f07e9c75a85b125fe0375b3feb6e7) Fix typo on ollama patch - [`135b57c`](https://github.com/open-webui/open-webui/commit/135b57ca8e55134efb92c35af60f1b850a65deb9) Update Placeholder.svelte - [`c8c4e16`](https://github.com/open-webui/open-webui/commit/c8c4e1642fb8e9ad718e52c4ebcb9b49293098a7) Merge branch 'open-webui:main' into correct-markdown-rendering-model-descriptions - [`beb1f3f`](https://github.com/open-webui/open-webui/commit/beb1f3f7fde7475783db29f6608839ee7cca0498) Merge branch 'open-webui:main' into system-prompt-resizing ### 📊 Changes **36 files changed** (+1547 additions, -1403 deletions) <details> <summary>View changed files</summary> 📝 `backend/open_webui/env.py` (+5 -0) 📝 `backend/open_webui/internal/db.py` (+4 -0) 📝 `backend/open_webui/retrieval/utils.py` (+13 -12) 📝 `backend/open_webui/routers/audio.py` (+14 -9) 📝 `backend/open_webui/routers/files.py` (+8 -7) 📝 `backend/open_webui/routers/images.py` (+5 -4) 📝 `backend/open_webui/routers/ollama.py` (+37 -36) 📝 `backend/open_webui/routers/openai.py` (+29 -29) 📝 `backend/open_webui/routers/retrieval.py` (+10 -0) 📝 `backend/open_webui/utils/chat.py` (+1 -1) 📝 `backend/open_webui/utils/telemetry/setup.py` (+17 -1) 📝 `pyproject.toml` (+1 -1) 📝 `src/lib/apis/auths/index.ts` (+2 -0) 📝 `src/lib/apis/index.ts` (+2 -1) 📝 `src/lib/components/AddServerModal.svelte` (+47 -14) 📝 `src/lib/components/chat/Chat.svelte` (+6 -6) 📝 `src/lib/components/chat/ChatPlaceholder.svelte` (+2 -2) 📝 `src/lib/components/chat/Controls/Controls.svelte` (+1 -1) 📝 `src/lib/components/chat/Messages/Markdown.svelte` (+2 -1) 📝 `src/lib/components/chat/Placeholder.svelte` (+8 -4) _...and 16 more files_ </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [ ] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Enhances the error message during Peewee database migrations to provide users with a helpful hint for troubleshooting connection failures. ### Added - None ### Changed - The `handle_peewee_migration` function in `backend/open_webui/internal/db.py` now logs a warning message suggesting that special characters in the database password should be URL-encoded if the connection fails. ### Deprecated - None ### Removed - None ### Fixed - Improves the user experience by providing clearer guidance for resolving a common database connection issue related to special characters in passwords. ### Security - None ### Breaking Changes - **BREAKING CHANGE**: None --- ### Additional Information - None ### Screenshots or Videos - None ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-25 11:58:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
confirmed
confirmed issue
core
documentation
enhancement
good first issue
help wanted
non-core
pull-request
Mirrored from GitHub Pull Request
 python
question
testing wanted
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/open-webui#39361
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?