[PR #15009] [MERGED] Feat: password button accessibility again #39306

New Issue

GiteaMirror · 2026-04-25T11:57:16-05:00

GiteaMirror commented

2026-04-25 11:57:16 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/15009
Author: @sinejespersen
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @tjbck

Base: dev ← Head: feature/password-button-accessibility-again

📝 Commits (5)

0e95af0 remove decorative svg from screen readers
53d044f add aria label to button with no other label
400c4c3 add aria pressed to toggle visibility button, to show current state
d167763 add label visible to screen readers to sensitive input
75883dc outline-hidden depend on high contrast mode

📊 Changes

2 files changed (+11 additions, -2 deletions)

View changed files

📝 src/lib/components/chat/Settings/Connections/Connection.svelte (+1 -1)
📝 src/lib/components/common/SensitiveInput.svelte (+10 -1)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Hide decorative svgs from screen readers
Add high contrast mode on sensitive input
Add aria-pressed to toggle button
Add <label to password input (Only visible to screen readers .sr-only)
Aria label to button that only has an svg inside

Added

N/A

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

RELATED TO: https://github.com/open-webui/open-webui/pull/14952

Closed because outline-hidden was removed, but it is not removed it is moved to <SensitiveInput

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/15009 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/password-button-accessibility-again` --- ### 📝 Commits (5) - [`0e95af0`](https://github.com/open-webui/open-webui/commit/0e95af01ea88a00a78f7c068e93d21007e18f00e) remove decorative svg from screen readers - [`53d044f`](https://github.com/open-webui/open-webui/commit/53d044f8a2c34880b94635350d92164c977e53a2) add aria label to button with no other label - [`400c4c3`](https://github.com/open-webui/open-webui/commit/400c4c3d12e55c188e6f8bb84ab6c521735216f2) add aria pressed to toggle visibility button, to show current state - [`d167763`](https://github.com/open-webui/open-webui/commit/d1677635a50861a29c85d8b3cd0f88e0ece8d465) add label visible to screen readers to sensitive input - [`75883dc`](https://github.com/open-webui/open-webui/commit/75883dc8355cae69aac2ce1b9c2b90c9a737baaa) outline-hidden depend on high contrast mode ### 📊 Changes **2 files changed** (+11 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/Connections/Connection.svelte` (+1 -1) 📝 `src/lib/components/common/SensitiveInput.svelte` (+10 -1) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Hide decorative svgs from screen readers - Add high contrast mode on sensitive input - Add `aria-pressed` to toggle button - Add `<label` to password input (Only visible to screen readers `.sr-only`) - Aria label to `button` that only has an svg inside ### Added N/A ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information **RELATED TO**: https://github.com/open-webui/open-webui/pull/14952 Closed because `outline-hidden` was removed, but it is not removed it is *moved* to `<SensitiveInput` ### Screenshots or Videos <img width="925" alt="Screenshot 2025-06-12 at 13 32 07" src="https://github.com/user-attachments/assets/7340dc45-a8eb-4cbd-921b-7cb7e3db5870" /> <img width="929" alt="Screenshot 2025-06-12 at 13 32 11" src="https://github.com/user-attachments/assets/11f221b1-3d8b-4e84-8763-36375fab2307" /> <img width="925" alt="Screenshot 2025-06-12 at 14 05 33" src="https://github.com/user-attachments/assets/fd00dc36-bb66-4e88-8115-cf2662ad3acd" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:57:16 -05:00

GiteaMirror closed this issue

2026-04-25 11:57:16 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39306