[PR #14959] [MERGED] Feature/accessibility edit connection modal #39293

New Issue

GiteaMirror · 2026-04-25T11:56:56-05:00

GiteaMirror commented

2026-04-25 11:56:56 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14959
Author: @sinejespersen
Created: 6/13/2025
Status: ✅ Merged
Merged: 6/14/2025
Merged by: @tjbck

Base: dev ← Head: feature/accessibility-edit-connection-modal

📝 Commits (10+)

a1034a4 correct classname to inputclassname as prop is named this
15efb07 add label to toggle connection button in configure connect modal
8b5f5bb add label to verify connection button
843810c add aria hidden to decorative svg
1160a03 change label for url to label instead of div
669a9f0 highContrastMode (for accessibility) on text color in add connection modal
85018dd high contrast mode on placeholder
47c65ba remove decorative svg from screen readers
ba9e9e8 add aria label to button with no label
b95bc72 add label for screen readers for model id input

📊 Changes

7 files changed (+81 additions, -22 deletions)

View changed files

📝 src/lib/components/AddConnectionModal.svelte (+67 -18)
📝 src/lib/components/common/Switch.svelte (+2 -0)
📝 src/lib/components/common/Tags.svelte (+2 -2)
📝 src/lib/components/common/Tags/TagInput.svelte (+3 -0)
📝 src/lib/components/common/Tags/TagList.svelte (+5 -2)
📝 src/lib/components/icons/Minus.svelte (+1 -0)
📝 src/lib/components/icons/Plus.svelte (+1 -0)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Decorative svgs hidden from screen readers
Added a bunch of aria labels to empty buttons
Made lists use <ul and <li, because using semantic html helps assistive technology
Added high contrast texts: labels, placeholders and such
Changed some divs into <label, because using semantic html helps assistive technology

Added

Add high contrast mode on menu items

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

ON

OFF

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14959 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/13/2025 **Status:** ✅ Merged **Merged:** 6/14/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/accessibility-edit-connection-modal` --- ### 📝 Commits (10+) - [`a1034a4`](https://github.com/open-webui/open-webui/commit/a1034a4ca37c9f417dcae2a553b7aec9561a0f90) correct classname to inputclassname as prop is named this - [`15efb07`](https://github.com/open-webui/open-webui/commit/15efb079613c94845702897414b2395073b6dea3) add label to toggle connection button in configure connect modal - [`8b5f5bb`](https://github.com/open-webui/open-webui/commit/8b5f5bb32788307ddb224d411014d8bc70003e1f) add label to verify connection button - [`843810c`](https://github.com/open-webui/open-webui/commit/843810cc9f6235c02af1cbb1cd989f13ac0fd2dc) add aria hidden to decorative svg - [`1160a03`](https://github.com/open-webui/open-webui/commit/1160a0364496ee279fd1e0aef93adc7270f30945) change label for url to label instead of div - [`669a9f0`](https://github.com/open-webui/open-webui/commit/669a9f07770d77d8895e5460d8d2be27fa9307d0) highContrastMode (for accessibility) on text color in add connection modal - [`85018dd`](https://github.com/open-webui/open-webui/commit/85018dd1069c91ef75fb0be92802c9d9b4734e26) high contrast mode on placeholder - [`47c65ba`](https://github.com/open-webui/open-webui/commit/47c65bac6c6a94bdae8b14786512fd4047714a70) remove decorative svg from screen readers - [`ba9e9e8`](https://github.com/open-webui/open-webui/commit/ba9e9e80957bca3ff92e5a639c7ae5ba4332ad39) add aria label to button with no label - [`b95bc72`](https://github.com/open-webui/open-webui/commit/b95bc727df67c5c3910150415b5cc6b78a8668ef) add label for screen readers for model id input ### 📊 Changes **7 files changed** (+81 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/AddConnectionModal.svelte` (+67 -18) 📝 `src/lib/components/common/Switch.svelte` (+2 -0) 📝 `src/lib/components/common/Tags.svelte` (+2 -2) 📝 `src/lib/components/common/Tags/TagInput.svelte` (+3 -0) 📝 `src/lib/components/common/Tags/TagList.svelte` (+5 -2) 📝 `src/lib/components/icons/Minus.svelte` (+1 -0) 📝 `src/lib/components/icons/Plus.svelte` (+1 -0) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description - Decorative svgs hidden from screen readers - Added a bunch of aria labels to empty buttons - Made lists use `<ul` and `<li`, because using semantic html helps assistive technology - Added high contrast texts: labels, placeholders and such - Changed some divs into `<label`, because using semantic html helps assistive technology ### Added - Add high contrast mode on menu items ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos ON <img width="931" alt="Screenshot 2025-06-13 at 14 45 26" src="https://github.com/user-attachments/assets/7694f3fd-0d2d-401f-b1ed-02e2e22000c7" /> <img width="933" alt="Screenshot 2025-06-13 at 14 40 22" src="https://github.com/user-attachments/assets/1da32885-2ab0-4188-95dd-b4db5750b89e" /> <img width="921" alt="Screenshot 2025-06-13 at 14 41 01" src="https://github.com/user-attachments/assets/2eac74f8-7715-448e-974e-3bc239ad6301" /> OFF <img width="919" alt="Screenshot 2025-06-13 at 14 41 35" src="https://github.com/user-attachments/assets/10f32941-0c78-4f0c-a111-bdaa68eaabce" /> <img width="940" alt="Screenshot 2025-06-13 at 14 41 21" src="https://github.com/user-attachments/assets/8f969876-3d8e-42ce-b7ed-3e0f09ebf367" /> <img width="925" alt="Screenshot 2025-06-13 at 14 41 15" src="https://github.com/user-attachments/assets/9b48704b-78b6-4ced-a8b9-01a3ee8ac2c7" /> <img width="926" alt="Screenshot 2025-06-13 at 14 41 48" src="https://github.com/user-attachments/assets/430a8e50-447e-4b0d-907b-979ee50ca60e" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:56:56 -05:00

GiteaMirror closed this issue

2026-04-25 11:56:57 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39293