[PR #14938] [CLOSED] fix: Add more to stores #39282

New Issue

GiteaMirror · 2026-04-25T11:56:36-05:00

GiteaMirror commented

2026-04-25 11:56:36 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14938
Author: @silentoplayz
Created: 6/12/2025
Status: ❌ Closed

Base: dev ← Head: HTMLToken-error-fix

📝 Commits (3)

094e5a2 fix: Add Iframe Sandbox Allow Options
d080fb7 fix: Add collapseCodeBlocks and expandDetails
fbea759 fix: update

📊 Changes

2 files changed (+53 additions, -5 deletions)

View changed files

📝 src/lib/components/chat/Messages/ResponseMessage.svelte (+13 -1)
📝 src/lib/stores/index.ts (+40 -4)

📄 Description

Pull Request Checklist

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Pull Request Checklist

Changelog Entry

Description

This pull request addresses a Property 'iframeSandboxAllowForms' does not exist on type 'Settings'. error by introducing new configuration options for iframe sandbox attributes within user settings. It also improves type safety for the emoji shortcodes conversion.

Added

Added iframeSandboxAllowForms and iframeSandboxAllowSameOrigin optional properties to the Settings type, allowing for more granular control over iframe sandbox attributes used in components like HTMLToken.svelte.

Changed

Improved type explicitness for the shortCodesToEmojis writable store's reduce method by adding explicit type annotations (Record<string, string>).
Modified the chatDirection property in the Settings type from required to optional, providing more flexibility for its presence in user settings.

Fixed

Fixed Property 'iframeSandboxAllowForms' does not exist on type 'Settings'. error observed in src\lib\components\chat\Messages\Markdown\HTMLToken.svelte by adding iframeSandboxAllowForms and iframeSandboxAllowSameOrigin to the Settings type.

Security

None (The addition of iframe sandbox options is a configuration change, not a direct security fix for an existing vulnerability).

Additional Information

These changes enhance the flexibility of user settings, improve the codebase's type safety, and resolve a specific type error related to iframe sandbox properties.
Related file: src\lib\components\chat\Messages\Markdown\HTMLToken.svelte

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14938 **Author:** [@silentoplayz](https://github.com/silentoplayz) **Created:** 6/12/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `HTMLToken-error-fix` --- ### 📝 Commits (3) - [`094e5a2`](https://github.com/open-webui/open-webui/commit/094e5a23edace9bb58284b81153c4c1f0a664d87) fix: Add Iframe Sandbox Allow Options - [`d080fb7`](https://github.com/open-webui/open-webui/commit/d080fb7bfeb57cb60db2d9e5bf01d19d1ee76f4c) fix: Add collapseCodeBlocks and expandDetails - [`fbea759`](https://github.com/open-webui/open-webui/commit/fbea759d632e9a8005b0e64c67e00cb540b353ea) fix: update ### 📊 Changes **2 files changed** (+53 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Messages/ResponseMessage.svelte` (+13 -1) 📝 `src/lib/stores/index.ts` (+40 -4) </details> ### 📄 Description # Pull Request Checklist **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Pull Request Checklist # Changelog Entry ### Description - This pull request addresses a `Property 'iframeSandboxAllowForms' does not exist on type 'Settings'.` error by introducing new configuration options for iframe sandbox attributes within user settings. It also improves type safety for the emoji shortcodes conversion. ### Added - Added `iframeSandboxAllowForms` and `iframeSandboxAllowSameOrigin` optional properties to the `Settings` type, allowing for more granular control over iframe sandbox attributes used in components like `HTMLToken.svelte`. ### Changed - Improved type explicitness for the `shortCodesToEmojis` writable store's `reduce` method by adding explicit type annotations (`Record<string, string>`). - Modified the `chatDirection` property in the `Settings` type from required to optional, providing more flexibility for its presence in user settings. ### Fixed - Fixed `Property 'iframeSandboxAllowForms' does not exist on type 'Settings'.` error observed in `src\lib\components\chat\Messages\Markdown\HTMLToken.svelte` by adding `iframeSandboxAllowForms` and `iframeSandboxAllowSameOrigin` to the `Settings` type. ### Security - None (The addition of iframe sandbox options is a configuration change, not a direct security fix for an existing vulnerability). --- ### Additional Information - These changes enhance the flexibility of user settings, improve the codebase's type safety, and resolve a specific type error related to iframe sandbox properties. - Related file: `src\lib\components\chat\Messages\Markdown\HTMLToken.svelte` ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:56:36 -05:00

GiteaMirror closed this issue

2026-04-25 11:56:37 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39282