[PR #14878] [MERGED] Feature: settings modal tab list #39256

New Issue

GiteaMirror · 2026-04-25T11:55:59-05:00

GiteaMirror commented

2026-04-25 11:55:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/open-webui/open-webui/pull/14878
Author: @sinejespersen
Created: 6/11/2025
Status: ✅ Merged
Merged: 6/11/2025
Merged by: @tjbck

Base: dev ← Head: feature/settings-modal-tab-list

📝 Commits (3)

6af9132 add roles tablist and tab to tabs in settings modal
aee60ad add aria-selected to tabs
5dd99a0 add aria-controls and ids to connect tabs to content

📊 Changes

10 files changed (+37 additions, -6 deletions)

View changed files

📝 src/lib/components/chat/Settings/About.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Account.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Audio.svelte (+1 -0)
📝 src/lib/components/chat/Settings/Chats.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Connections.svelte (+1 -0)
📝 src/lib/components/chat/Settings/General.svelte (+1 -1)
📝 src/lib/components/chat/Settings/Interface.svelte (+1 -0)
📝 src/lib/components/chat/Settings/Personalization.svelte (+1 -0)
📝 src/lib/components/chat/Settings/Tools.svelte (+1 -0)
📝 src/lib/components/chat/SettingsModal.svelte (+28 -2)

📄 Description

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

https://github.com/open-webui/open-webui/discussions/8908

Before submitting, make sure you've checked the following:

Target branch: Please verify that the pull request targets the dev branch.
Description: Provide a concise description of the changes made in this pull request.
Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
Documentation: Have you updated relevant documentation Open WebUI Docs, or other documentation sources?
Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
Testing: Have you written and run sufficient tests to validate the changes?
Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
- BREAKING CHANGE: Significant changes that may affect compatibility
- build: Changes that affect the build system or external dependencies
- ci: Changes to our continuous integration processes or workflows
- chore: Refactor, cleanup, or other non-functional code changes
- docs: Documentation update or addition
- feat: Introduces a new feature or enhancement to the codebase
- fix: Bug fix or error correction
- i18n: Internationalization or localization changes
- perf: Performance improvement
- refactor: Code restructuring for better maintainability, readability, or scalability
- style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
- test: Adding missing tests or correcting existing tests
- WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

Structural changes, no visible changes:

Added tab-list role and tab-role
Added aria selected on tabs
Add aria-controls to connect content to tab

Added

Added tab-list role and tab-role
Added aria selected on tabs
Add aria-controls to connect content to tab

Changed

N/A

Deprecated

N/A

Removed

N/A

Fixed

N/A

Security

N/A

Breaking Changes

N/A

Additional Information

N/A

Screenshots or Videos

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/open-webui/open-webui/pull/14878 **Author:** [@sinejespersen](https://github.com/sinejespersen) **Created:** 6/11/2025 **Status:** ✅ Merged **Merged:** 6/11/2025 **Merged by:** [@tjbck](https://github.com/tjbck) **Base:** `dev` ← **Head:** `feature/settings-modal-tab-list` --- ### 📝 Commits (3) - [`6af9132`](https://github.com/open-webui/open-webui/commit/6af91325e2eda7fb692d6060349622a05a9b463a) add roles tablist and tab to tabs in settings modal - [`aee60ad`](https://github.com/open-webui/open-webui/commit/aee60add1d6e40e5d759635052e3242879d59c38) add aria-selected to tabs - [`5dd99a0`](https://github.com/open-webui/open-webui/commit/5dd99a0ea7ededa8facf1ed56096fb26b2444f17) add aria-controls and ids to connect tabs to content ### 📊 Changes **10 files changed** (+37 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `src/lib/components/chat/Settings/About.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Account.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Audio.svelte` (+1 -0) 📝 `src/lib/components/chat/Settings/Chats.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Connections.svelte` (+1 -0) 📝 `src/lib/components/chat/Settings/General.svelte` (+1 -1) 📝 `src/lib/components/chat/Settings/Interface.svelte` (+1 -0) 📝 `src/lib/components/chat/Settings/Personalization.svelte` (+1 -0) 📝 `src/lib/components/chat/Settings/Tools.svelte` (+1 -0) 📝 `src/lib/components/chat/SettingsModal.svelte` (+28 -2) </details> ### 📄 Description # Pull Request Checklist ### Note to first-time contributors: Please open a discussion post in [Discussions](https://github.com/open-webui/open-webui/discussions) and describe your changes before submitting a pull request. https://github.com/open-webui/open-webui/discussions/8908 **Before submitting, make sure you've checked the following:** - [x] **Target branch:** Please verify that the pull request targets the `dev` branch. - [x] **Description:** Provide a concise description of the changes made in this pull request. - [x] **Changelog:** Ensure a changelog entry following the format of [Keep a Changelog](https://keepachangelog.com/) is added at the bottom of the PR description. - [x] **Documentation:** Have you updated relevant documentation [Open WebUI Docs](https://github.com/open-webui/docs), or other documentation sources? - [x] **Dependencies:** Are there any new dependencies? Have you updated the dependency versions in the documentation? - [x] **Testing:** Have you written and run sufficient tests to validate the changes? - [x] **Code review:** Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards? - [x] **Prefix:** To clearly categorize this pull request, prefix the pull request title using one of the following: - **BREAKING CHANGE**: Significant changes that may affect compatibility - **build**: Changes that affect the build system or external dependencies - **ci**: Changes to our continuous integration processes or workflows - **chore**: Refactor, cleanup, or other non-functional code changes - **docs**: Documentation update or addition - **feat**: Introduces a new feature or enhancement to the codebase - **fix**: Bug fix or error correction - **i18n**: Internationalization or localization changes - **perf**: Performance improvement - **refactor**: Code restructuring for better maintainability, readability, or scalability - **style**: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.) - **test**: Adding missing tests or correcting existing tests - **WIP**: Work in progress, a temporary label for incomplete or ongoing work # Changelog Entry ### Description Structural changes, no visible changes: - Added `tab-list` role and `tab`-role - Added aria selected on tabs - Add `aria-controls` to connect content to tab ### Added - Added `tab-list` role and `tab`-role - Added aria selected on tabs - Add `aria-controls` to connect content to tab ### Changed N/A ### Deprecated N/A ### Removed N/A ### Fixed N/A ### Security N/A ### Breaking Changes N/A --- ### Additional Information N/A ### Screenshots or Videos <img width="921" alt="Screenshot 2025-06-11 at 14 10 25" src="https://github.com/user-attachments/assets/2771a0bf-fa74-49bf-8378-b0b284a8513e" /> <img width="437" alt="Screenshot 2025-06-11 at 14 10 14" src="https://github.com/user-attachments/assets/e63e3394-81e7-4c9d-913f-02136938da2a" /> ### Contributor License Agreement By submitting this pull request, I confirm that I have read and fully agree to the [Contributor License Agreement (CLA)](/CONTRIBUTOR_LICENSE_AGREEMENT), and I am providing my contributions under its terms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-25 11:55:59 -05:00

GiteaMirror closed this issue

2026-04-25 11:56:00 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/open-webui#39256